fix: add react-refresh as a dependency for templates

[pmmmwh]

This fixes #9446 - basically I've added react-refresh to the starting templates so that the peerDependency from react-refresh-webpack-plugin would properly resolve in stricter module systems (e.g. Yarn 2 and PnP). It is already a dependency of react-scripts but that does not suffice because imports to react-refresh/runtime will be injected to the users' bundle.

[mrmckeb]

Thanks for this @pmmmwh!

We also have community templates, it might be better to add it here?
https://github.com/facebook/create-react-app/blob/master/packages/create-react-app/createReactApp.js#L434

Maybe @iansu and/or @ianschmitz have some thoughts too.

[pmmmwh]

I've update the PR to install react-refresh within the CRA command instead - I've made the changes where I think is necessary, but please feel free to correct me cause I'm not very familiar with the CLI's structure!

[merceyz]

This should be fixed in the plugin instead by having it resolve it before injecting the import - pmmmwh/react-refresh-webpack-plugin#230

[pmmmwh]

This should be fixed in the plugin instead by having it resolve it before injecting the import - pmmmwh/react-refresh-webpack-plugin#230

Do you think that this is still needed after the fix in the plugin?

[merceyz]

Do you think that this is still needed after the fix in the plugin?

Nope, it's not needed anymore. The plugin is updated in #9872 together with other dependency fixes

[pmmmwh]

Superseded by #9872