Small spelling/grammar updates #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wincent
reviewed
Jul 14, 2017
src/index.js
Outdated
| @@ -12,7 +12,7 @@ | |||
| // of values or Errors. | |||
| type BatchLoadFn<K, V> = (keys: Array<K>) => Promise<Array<V | Error>>; | |||
|
|
|||
| // Optionally turn off batching or caching or provide a cache key function or a | |||
| // Optionally turn off batching or caching, and provide a cache key function or | |||
There was a problem hiding this comment.
Strictly speaking, this change makes things worse. Given that all the properties are optional, "or" is the appropriate conjunction here. So I'll revert this hunk before merging. (To be honest, this comment has close to zero value anyway because it just reformulates what's encoded in the type using sloppier language. I wouldn't be averse to just deleting it.)
|
Thanks for this @wub! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.