Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatchLoader as an adapted Ruby implementation #99

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

exAspArk
Copy link
Contributor

If you port DataLoader to another language, please open an issue to include a link from this repository.

Hi,

I recently created BatchLoader – an adapted Ruby implementation of DataLoader.

The primary difference is that BatchLoader doesn't use Promises, which are not so popular in Ruby since it doesn't have an asynchronous nature. Instead, BatchLoader uses the idea of "lazy" objects which are used in the Ruby standard library.

In addition to the detailed description in README, I wrote a blog post about batching in Ruby, which also describes the gem.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d08abd6 on exAspArk:batch-loader into 25cf990 on facebook:master.

@wincent
Copy link
Contributor

wincent commented Aug 16, 2017

Thanks @exAspArk. While this isn't so much an "Other implementation" as a different solution in the same problem space, I think it's reasonable to include here given that the differences are explicitly called out in the README, and you include a GraphQL example, which is nice.

@wincent wincent merged commit 75a0dfb into graphql:master Aug 16, 2017
@exAspArk
Copy link
Contributor Author

@wincent thank you! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants