Skip to content

Commit

Permalink
Display resolver ip in dnswatch detailed
Browse files Browse the repository at this point in the history
Summary: It's useful information to have in detailed view

Reviewed By: abulimov

Differential Revision: D48227773

fbshipit-source-id: a2bf5e9cd4c7e980e61eccc0e27762a5613c6e97
  • Loading branch information
deathowl authored and facebook-github-bot committed Aug 10, 2023
1 parent 31fedc1 commit b15b375
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
1 change: 1 addition & 0 deletions dnswatch/snoop/printer.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ func (d *DisplayInfo) DetailedString() string {
s += ";; opcode: " + dnsPkt.OpCode.String()
s += ", status: " + dnsPkt.ResponseCode.String()
s += ", id: " + strconv.Itoa(int(dnsPkt.ID)) + "\n"
s += ";; resolver ip: " + d.responseAddr.String() + "\n"

s += ";; flags:"
if dnsPkt.QR {
Expand Down
18 changes: 9 additions & 9 deletions dnswatch/snoop/printer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,15 @@ func TestDisplayInfoString(t *testing.T) {
require.Equal(t, "true,", res[8])
require.Equal(t, "V2Random", res[5])
require.Equal(t, "10", res[12])
require.Equal(t, "QUERY:", res[23])
require.Equal(t, "1,", res[24])
require.Equal(t, "ANSWER:", res[25])
require.Equal(t, "1,", res[26])
require.Equal(t, "AUTHORITY:", res[27])
require.Equal(t, "0,", res[28])
require.Equal(t, "ADDITIONAL:", res[29])
require.Equal(t, "0", res[30])
require.Equal(t, ";question.name", res[34])
require.Equal(t, "QUERY:", res[27])
require.Equal(t, "1,", res[28])
require.Equal(t, "ANSWER:", res[29])
require.Equal(t, "1,", res[30])
require.Equal(t, "AUTHORITY:", res[31])
require.Equal(t, "0,", res[32])
require.Equal(t, "ADDITIONAL:", res[33])
require.Equal(t, "0", res[34])
require.Equal(t, ";question.name", res[38])

d.query = nil
res = strings.Fields(d.DetailedString())
Expand Down

0 comments on commit b15b375

Please sign in to comment.