rocksdb: add WaitForCompact() #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51029439 |
Summary: RocksDB 8.7 was released with C bindings for `WaitForCompact()` call that was added on our request. Update CGO wrapper with those bindings. Reviewed By: leoleovich Differential Revision: D51029439
abulimov
added a commit
to abulimov/dns
that referenced
this pull request
Nov 7, 2023
Summary: RocksDB 8.7 was released with C bindings for `WaitForCompact()` call that was added on our request. Update CGO wrapper with those bindings. Reviewed By: leoleovich Differential Revision: D51029439
abulimov
force-pushed
the
export-D51029439
branch
from
7aebeb2
to
b42bace
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51029439 |
abulimov
force-pushed
the
export-D51029439
branch
from
b42bace
to
a2e6827
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51029439 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 65.39% 68.05% +2.66%
==========================================
Files 62 7 -55
Lines 6852 335 -6517
==========================================
- Hits 4481 228 -4253
+ Misses 2090 106 -1984
+ Partials 281 1 -280 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in a135ec1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: RocksDB 8.7 was released with C bindings for
WaitForCompact()call that was added on our request. Update CGO wrapper with those bindings.Reviewed By: leoleovich
Differential Revision: D51029439