Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Author name is always same for all of the pages #2952

Closed
apsdehal opened this issue Jun 17, 2020 · 8 comments
Closed

[v2] Author name is always same for all of the pages #2952

apsdehal opened this issue Jun 17, 2020 · 8 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@apsdehal
Copy link

apsdehal commented Jun 17, 2020

🐛 Bug Report

Whenever an update is made using GitHub action to the website using yarn build and then deploy to gh pages, the author is always the same for all of the pages.

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

  1. Have a look https://mmf.sh/docs

Expected behavior

Author should be the actual person who last updated the docs

Actual Behavior

The author is same and the person who made the recent commit

(Write what happened. Add screenshots, if applicable.)

Your Environment

Docusaurus version used:2.0.0-alpha.56
Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0): Node version: v12.17.0
Operating system and version (desktop or mobile): MacOS 10.14.6 (desktop and mobile both)

Reproducible Demo

(Paste the link to an example repo, including a siteConfig.js, and exact instructions to reproduce the issue.)

https://mmf.sh/docs

Seems somewhat related to #2798

@apsdehal apsdehal added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Jun 17, 2020
@yangshun yangshun removed the status: needs triage This issue has not been triaged by maintainers label Jun 17, 2020
@yangshun
Copy link
Contributor

Agreed. Seems like a GitHub actions thingy. Local deployment should work fine.

@slorber
Copy link
Collaborator

slorber commented Jun 17, 2020

afaik Github Pages deployment need to commit to a gh-pages branch to deploy, and we read the github history to know which doc has been updated by which git user last

https://github.com/facebookresearch/mmf/commits/gh-pages

as you can see, reading this history could only lead to the github bot :(

Honestly I'm not fan of using github pages anymore. Options like Netlify are free, much simpler to setup and do not need to commit anything to the repo.

@slorber
Copy link
Collaborator

slorber commented Jun 17, 2020

I've opened a doc issue here: #2953

@apsdehal wonder if you could try to host on Netlify or Vercel, and give me feedback on how simple it was compared to Github actions?

@Jason-2020
Copy link

Jason-2020 commented Jun 17, 2020

See the comment for solution. #2798 (comment)
It's not only v2 or Github thing. It's just behaviour of your CI environment.

@slorber
Copy link
Collaborator

slorber commented Jun 18, 2020

thanks @Jason-2020

@apsdehal can you tell if this works great for your usecase?

@slorber
Copy link
Collaborator

slorber commented Jun 23, 2020

@apsdehal I'm closing as I think @Jason-2020 gave a solution.

@praveenkumar6722
Copy link

I still see the issue, my code already has depth configured.

  - uses: actions/checkout@v3
    with:
      fetch-depth: 0

@ntucker
Copy link
Contributor

ntucker commented Aug 14, 2023

For vercel you'll need to setup github actions yourself as their integration doesn't allow non-zero fetch-depth: vercel/vercel#5737 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

No branches or pull requests

6 participants