Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Source Infima framework #3575

Closed
Simek opened this issue Oct 12, 2020 · 5 comments
Closed

Open Source Infima framework #3575

Simek opened this issue Oct 12, 2020 · 5 comments
Labels
proposal This issue is a proposal, usually non-trivial change

Comments

@Simek
Copy link
Contributor

Simek commented Oct 12, 2020 •
edited
Loading

馃挜 Proposal

Currently the Docusurus styling is based on the Infima framework which is a FB Incubator project (currently closed source).

Infima is not yet ready for production use and is being developed alongside Docusaurus 2

I acknowledge this statement, but Infima is used in default theme, most of Docusaurus V2 websites are based on theme-classic package and they are already running "in production": https://v2.docusaurus.io/showcase

Since V2 is getting more popular and users are migrating to the new version it would be nice to have an access to the core theme files, so bug fixing or improving the theme would be easier. Currently users had to overwrite the Infima variables and fix encountered bugs or issues with Infima styling in their own CSS/SASS/SCSS files (example form the Docusaurus V2 website). There is also no place to report the problems or submit PRs.

If it is not possible to open source the project, the theme based on Infima should not be a default or a recommended choice for the V2 users (because of limited accessibility and customizability) and Facebook Open Source logo and GitHub link should be removed from the Infima website to avoid users confusion.

Have you read the Contributing Guidelines on issues?

Yes
@Simek Simek added status: needs triage This issue has not been triaged by maintainers proposal This issue is a proposal, usually non-trivial change labels Oct 12, 2020
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Oct 12, 2020
@slorber slorber mentioned this issue Oct 13, 2020
Closed
@slorber slorber mentioned this issue Oct 26, 2020
Closed
@yangshun
Copy link
Contributor

Apologies for the delay. I'm working on making the repo public just to give more visibility into the source code. Will do so by the end of the week.

@Simek
Copy link
Contributor Author

Simek commented Nov 18, 2020

@yangshun Friendly bump 馃槈 What's the current status of OSing Infima?

@Simek
Copy link
Contributor Author

Simek commented Nov 19, 2020 •
edited
Loading

@yangshun Another issue emerges - #3739 (comment)

@yangshun
Copy link
Contributor

@Simek We're done with the necessary checks in the internal repo, just need one final step of squashing the commit history before the Open Source team can make the repo public. As this week is an off-week for FB employees, we estimate that the repo will only be officially made public early next week. Thanks for your patience!

@yangshun
Copy link
Contributor

yangshun commented Dec 2, 2020 •
edited
Loading

The repo is public! - https://github.com/facebookincubator/infima/

Thank you for your patience 鉂わ笍

@yangshun yangshun closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal This issue is a proposal, usually non-trivial change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Simek @slorber @yangshun