Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accecability problem in <div role=region"><a class="skipToContent"> #7981

Closed
6 of 7 tasks
YoniChechik opened this issue Aug 21, 2022 · 2 comments · Fixed by #7982
Closed
6 of 7 tasks

Accecability problem in <div role=region"><a class="skipToContent"> #7981

YoniChechik opened this issue Aug 21, 2022 · 2 comments · Fixed by #7982
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: a11y Related to accessibility concerns of the default theme status: accepting pr This issue has been accepted, and we are looking for community contributors to implement this

Comments

@YoniChechik
Copy link
Contributor

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

missing aria-label in <div role=region"><a class="skipToContent">

probebly should be <div role=region" aria-label="skip To Content"><a class="skipToContent">
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/region_role

Reproducible demo

No response

Steps to reproduce

above

Expected behavior

above

Actual behavior

above

Your environment

happens in all docusaurus sites

Self-service

  • I'd be willing to fix this bug myself.
@YoniChechik YoniChechik added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Aug 21, 2022
@Josh-Cena Josh-Cena added status: accepting pr This issue has been accepted, and we are looking for community contributors to implement this domain: a11y Related to accessibility concerns of the default theme and removed status: needs triage This issue has not been triaged by maintainers labels Aug 21, 2022
@Josh-Cena
Copy link
Collaborator

I think this makes sense. Would you want to send a PR?

@YoniChechik YoniChechik mentioned this issue Aug 21, 2022
Merged
3 tasks
@YoniChechik
Copy link
Contributor Author

@Josh-Cena PR sent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: a11y Related to accessibility concerns of the default theme status: accepting pr This issue has been accepted, and we are looking for community contributors to implement this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theme): add aria-label to skip to content link region
2 participants
@YoniChechik @Josh-Cena