Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar not positioned correctly #7

Closed
sdwilsh opened this issue Jul 11, 2017 · 11 comments
Closed

Search bar not positioned correctly #7

sdwilsh opened this issue Jul 11, 2017 · 11 comments

Comments

@sdwilsh
Copy link
Contributor

sdwilsh commented Jul 11, 2017

I'm creating a new site, and I loaded the site in Firefox:
capture

Appears to be broken in Chrome too.

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Jul 11, 2017

This appears to happen after page load.

@deltice
Copy link
Contributor

deltice commented Jul 11, 2017

I explicitly fixed this issue at some point before, and it is positioned fine for me both running the server in Firefox or Chrome and deployed on an example site here. Does it look mispositioned on the example site as well? I running this on macOS and the website was deployed on an ubuntu server.

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Jul 11, 2017

Is it possible that you haven't pushed a new package to npm? I'm doing this following the instructions in the README.md.

@deltice
Copy link
Contributor

deltice commented Jul 11, 2017

I'm testing using the version of Docusaurus currently published to npm so I'm not sure how to duplicate the issue. Are you also running on macOS and using node 6.10.3?

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Jul 11, 2017 via email

@deltice
Copy link
Contributor

deltice commented Jul 12, 2017

I'm trying to recreate the issue and have installed Docusaurus on my dev server. Can you help me with how would I access the locally run server through a browser?

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Jul 12, 2017

@JoelMarcey can help you get fbsource checked out, and you'll need to apply D5409956 to your tree. After that, go to ~/local/fbsource/fbcode/experimental/pjameson/buckit/website, update the siteConfig.js to enable search, and then you can start it with port 8080. From there, you just access your server by it's hostname.

@JoelMarcey
Copy link
Contributor

I am getting the same bad search box positioning running locally (not on a devserver).

screenshot 2017-07-12 14 28 37

@deltice
Copy link
Contributor

deltice commented Jul 12, 2017

Ah okay I've now recreated the issue on my own machine as well, but I'm not sure exactly what's causing it. It works fine in one repo but not in another. I will spend some time to try to fix this.

@deltice
Copy link
Contributor

deltice commented Jul 13, 2017

Added a fix in #16, but I'm not too sure if this is the proper conventional way to fix the issue, and where in the .css file to place the change. Any feedback on that would be great!

@deltice
Copy link
Contributor

deltice commented Jul 17, 2017

Fix in #16 should handle this fine

@deltice deltice closed this as completed Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants