Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nested admonitions #8302

Closed
5 of 7 tasks
lebalz opened this issue Nov 8, 2022 · 0 comments · Fixed by #8303
Closed
5 of 7 tasks

support nested admonitions #8302

lebalz opened this issue Nov 8, 2022 · 0 comments · Fixed by #8303
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@lebalz
Copy link
Contributor

lebalz commented Nov 8, 2022

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

When nesting admonitions, the first seen stop-word (Line starting with :::) exits the first admonition block.

Reproducible demo

No response

Steps to reproduce

  1. Add the following snippet with nested admonitions to a markdown page
:::info Weather
On nice days, you can enjoy skiing in the mountains.

:::danger Storms
Take care of snowstorms...
:::

:::

Expected behavior

expected

Actual behavior

current

Your environment

  • Docusaurus version used: 2.2.0

Self-service

  • I'd be willing to fix this bug myself.
@lebalz lebalz added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Nov 8, 2022
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Nov 9, 2022
@lebalz lebalz changed the title fix(admonitions): support nested admonitions support nested admonitions Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants