Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant 'navigation' text in aria-label for Docs pages navigation #8834

Closed
7 tasks done
wwu-stephanie opened this issue Mar 27, 2023 · 0 comments · Fixed by #8842
Closed
7 tasks done

Redundant 'navigation' text in aria-label for Docs pages navigation #8834

wwu-stephanie opened this issue Mar 27, 2023 · 0 comments · Fixed by #8842
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: a11y Related to accessibility concerns of the default theme good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@wwu-stephanie
Copy link

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

On the pagination nav, the aria-label attribute is set as "Docs pages navigation." The word navigation is redundant, since it appears inside a <nav> element. This results in it being read out loud like "Docs pages navigation navigation region" or something similar.

Just for context: other navigation elements on the page seem to take this into account already, for example the "Pattern navigation" aria-label is just "Pattern"

Reproducible demo

No response

Steps to reproduce

  1. Start JAWS
  2. Navigate to https://docusaurus.io/docs/next
  3. Tab to the "Docs pages navigation navigation region"

Alternatively:

  1. Navigate to https://docusaurus.io/docs/next
  2. Scroll to bottom of page
  3. Inspect "Next Getting Started" page element
  4. See aria-label on <nav class="pagination-nav docusaurus-mt-lg" aria-label="Docs pages navigation">

Expected behavior

The region should announce as "Docs pages navigation region"

Actual behavior

"Docs pages navigation navigation region" (e.g. navigation is repeated)

Your environment

Self-service

  • I'd be willing to fix this bug myself.
@wwu-stephanie wwu-stephanie added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Mar 27, 2023
@Josh-Cena Josh-Cena added good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. domain: a11y Related to accessibility concerns of the default theme and removed status: needs triage This issue has not been triaged by maintainers labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: a11y Related to accessibility concerns of the default theme good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants