Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse sidebar button works strange. #8918

Closed
2 of 7 tasks
mihilt opened this issue Apr 24, 2023 · 5 comments · Fixed by #8971
Closed
2 of 7 tasks

Collapse sidebar button works strange. #8918

mihilt opened this issue Apr 24, 2023 · 5 comments · Fixed by #8971
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@mihilt
Copy link

mihilt commented Apr 24, 2023

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

In https://docusaurus.io/docs, I can see collapse side bar button at the bottom left.
And when I collapse it, it turns weird.
The way to solve this problem is clicking menu that can expand.

I think bug happens because there is a problem between expand menu button and collapse side bar button.

docusaurus_strange_collapse.mp4

Reproducible demo

No response

Steps to reproduce

Visit https://docusaurus.io/docs and act like the video above.

Expected behavior

It need to collapse and expand properly.

Actual behavior

It works something weird.

Your environment

  • Public site URL: https://docusaurus.io/docs
  • Docusaurus version used: Maybe latest version (2.4.0)
  • Environment name and version (e.g. Chrome 89, Node.js 16.4): Chrome
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS): MacOS

Self-service

  • I'd be willing to fix this bug myself.
@mihilt mihilt added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 24, 2023
@Josh-Cena
Copy link
Collaborator

Fixed by #8906

@Josh-Cena Josh-Cena closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
@Josh-Cena Josh-Cena added closed: duplicate This issue or pull request already exists in another issue or pull request and removed bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 24, 2023
@slorber
Copy link
Collaborator

slorber commented Apr 26, 2023

Oups, not fixed, can still reproduce this on our website, this is not supposed to happen:

CleanShot 2023-04-26 at 18 12 48@2x

@slorber slorber reopened this Apr 26, 2023
@slorber slorber added bug An error in the Docusaurus core causing instability or issues with its execution closed: duplicate This issue or pull request already exists in another issue or pull request and removed closed: duplicate This issue or pull request already exists in another issue or pull request labels Apr 26, 2023
@mud1tx
Copy link

mud1tx commented May 11, 2023

@mihilt I can work on this issue please assign it to me.

@mihilt
Copy link
Author

mihilt commented May 11, 2023

@mud1tx I'm not the maintainer of this repository and I also don't have any permission to set someone in assignees.

@slorber
Copy link
Collaborator

slorber commented May 12, 2023

@mud1tx if you want to contribute to little issues like this one the best is to send a PR directly.

Unless the PR requires lots of code and a design phase it's better to show us some code asap.

I don't think this issue would have been so easy for an external contributor to fix, so I fixed it here already: #8971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants