Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode not sticking on Brave Browser #9887

Closed
2 of 7 tasks
cmo-pomerium opened this issue Feb 24, 2024 · 1 comment
Closed
2 of 7 tasks

Dark mode not sticking on Brave Browser #9887

cmo-pomerium opened this issue Feb 24, 2024 · 1 comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: can't repro This bug is because of some local setup that can't be reproduced.

Comments

@cmo-pomerium
Copy link

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

Dark mode is not being "remembered" by Docusaurus when I use Brave Browser upon page refresh.

Reproducible demo

No response

Steps to reproduce

I discovered this while on Pomerium's docusaurus, but it's the same on https://docusaurus.io/docs

Step 1: Toggle dark mode.
Step 2: refresh the page (I use F5)
Step 3: See the page is no longer dark mode.

Expected behavior

It used to retain dark mode unless I completely clear cache/cookies.

Actual behavior

I refresh the page and it's now light mode.

For what it's worth, this seems to be Brave Browser only. I tested on Chrome and that's fine. Additionally, if I set to dark mode and click around documentation, it retains dark mode until refresh (or I enter docs again).

Your environment

Self-service

  • I'd be willing to fix this bug myself.
@cmo-pomerium cmo-pomerium added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Feb 24, 2024
@slorber slorber added closed: can't repro This bug is because of some local setup that can't be reproduced. and removed status: needs triage This issue has not been triaged by maintainers labels Feb 24, 2024
@slorber
Copy link
Collaborator

slorber commented Feb 24, 2024

I downloaded Brave on macOS and it works perfectly fine on both our site, and on https://www.pomerium.com/docs

If it doesn't work, it is either a Brave Ubuntu bug (unlikely), or you turned on some privacy/security setting that prevents us from using localStorage, or you use browser extensions that prevent it. If you don't know how to fix it, I'd suggest reinstalling Brave from scratch and disabling all extensions.

Ask a colleague to test under Brave and you'll see it works fine for them.

@slorber slorber closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: can't repro This bug is because of some local setup that can't be reproduced.
Projects
None yet
Development

No branches or pull requests

2 participants