Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pure examples in github action deployment examples #9955

Closed
1 of 2 tasks
nickswiss opened this issue Mar 15, 2024 · 1 comment
Closed
1 of 2 tasks

Use pure examples in github action deployment examples #9955

nickswiss opened this issue Mar 15, 2024 · 1 comment
Labels
documentation The issue is related to the documentation of Docusaurus

Comments

@nickswiss
Copy link

Have you read the Contributing Guidelines on issues?

Description

The documentation for github acions deployment is using third party packages that help, but obfiscate from the pure commands required to perform a deploy.
The third party github actions - namely peaceiris/actions-gh-pages@v3 and webfactory/ssh-agent are not from verified creators or certified from github. I would much prefer commands required absent of any third party libraries and the commands required assuming only docusaurus library is installed on the run doing the deployment. I do not think this needs to be removed as in most cases it can be used, but for organizations with finer security requirements of the actions they are using, these documents are not great examples and some pure examples would help.

Self-service

  • I'd be willing to address this documentation request myself.
@nickswiss nickswiss added documentation The issue is related to the documentation of Docusaurus status: needs triage This issue has not been triaged by maintainers labels Mar 15, 2024
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Mar 15, 2024
@slorber
Copy link
Collaborator

slorber commented Mar 15, 2024

The peaceiris/actions-gh-pages action is being replaced by an official one as part of a PR currently under review: #9937

Regarding the other one, if you have a concrete alternative to suggest to the documented workflow, please open a doc PR directly.

@slorber slorber closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation The issue is related to the documentation of Docusaurus
Projects
None yet
Development

No branches or pull requests

2 participants