This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
Improve Windows handling of certain exceptions. #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,8 @@ char const *Stringify::ExceptionCode(DWORD code) { | |||
| DO_STRINGIFY(EXCEPTION_PRIV_INSTRUCTION) | |||
| DO_STRINGIFY(EXCEPTION_SINGLE_STEP) | |||
| DO_STRINGIFY(EXCEPTION_STACK_OVERFLOW) | |||
| case 0xE06D7363: | |||
There was a problem hiding this comment.
i'd make a #define or a const for this number
There was a problem hiding this comment.
Somehow I knew that this was not gonna pass code review but still decided to write that shit 😆
This code is used for C++ exceptions thrown by user code.
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.