This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
Use absolute paths for library names in svr4 packets when possible #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
@facebook-github-bot shipit What should we do about this patch then? Wait for the LLDB one to go in and cherry-pick it to release_38? |
|
Yeah, I'll merge it to master today. I can put in some cherry-picks for the release_38 branch after that, and this would be one of them. Also not sure how bad of a problem the duplication is? Because I assume release_37 will also have the same issue, and I don't really want to deal with cherry-picking down to that branch. |
|
Committed as 3597b3b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This may cause library duplication on Tizen in some cases without this lldb patch - http://reviews.llvm.org/D19557.