This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 74
Remove perl5 and otp installs on travis #504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sas
suggested changes
Aug 1, 2017
Support/Testing/Travis/script.sh
Outdated
# In the home directory, /home/travis/perl5 takes up roughly 1.1GB of space and /home/travis/otp takes | ||
# up roughly 3.0GB. We should be able to recover this space on travis by removing these things, since | ||
# we never use them. | ||
if [ -e "~/perl5" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to check if the folder exists because you're using rm -f
anyway.
Support/Testing/Travis/script.sh
Outdated
if [ -e "~/perl5" ]; then | ||
rm -rf ~/perl5 | ||
fi | ||
if [ -e "~/otp" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
Support/Testing/Travis/script.sh
Outdated
@@ -14,6 +14,17 @@ source "$top/Support/Scripts/common.sh" | |||
|
|||
cformat="clang-format-4.0" | |||
|
|||
# We're running out of disk space on Travis. This is a dirty, dirty hack. We shouldn't have to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure these lines are less than 80 columns?
522c1e7
to
d410a48
Compare
sas
reviewed
Aug 9, 2017
|
||
set -eu | ||
|
||
# We're running out of disk space on Travis. This is a dirty hack. We shouldn't have to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
80 columns
sas
approved these changes
Aug 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is shitty hack. I feel bad about doing this, but I think it should fix our things in the short term while we come up with a better solution for the long term. I'm thinking we can probably play around with Travis settings until we find a sweet spot, but that will take more time to read the documentation and engage the Travis community.