-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese time dimension #646
Conversation
This looks good! I'll have an internal Japanese speaker review it. Can you remove commented-out corpora tests? |
CI failure seems unrelated, like a transient windows runner bug EDIT: I restarted CI and it looks good now. |
That will be super useful. I removed the commented corpus. Thanks! |
@chessai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Hi @chessai, do you have any news about the review of this PR from the internal Japanese speaker? |
Hi @udiu, sorry for the delay. The code received an internal review from Japanese speakers and I need to forward them along here (Normally, I would handle them myself internally, but my confidence that I can do so with Japanese is very low, so I'm going to forward them out externally) |
Add the most common rules for Japanese time dimension.