Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese time dimension #646

Closed
wants to merge 4 commits into from

Conversation

udiu
Copy link
Contributor

@udiu udiu commented Aug 27, 2021

Add the most common rules for Japanese time dimension.

@chessai
Copy link
Contributor

chessai commented Aug 27, 2021

This looks good! I'll have an internal Japanese speaker review it. Can you remove commented-out corpora tests?

@chessai
Copy link
Contributor

chessai commented Aug 27, 2021

CI failure seems unrelated, like a transient windows runner bug

EDIT: I restarted CI and it looks good now.

@udiu
Copy link
Contributor Author

udiu commented Aug 30, 2021

This looks good! I'll have an internal Japanese speaker review it. Can you remove commented-out corpora tests?

That will be super useful. I removed the commented corpus. Thanks!

@facebook-github-bot
Copy link

@chessai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@udiu
Copy link
Contributor Author

udiu commented Sep 16, 2021

Hi @chessai, do you have any news about the review of this PR from the internal Japanese speaker?

@chessai
Copy link
Contributor

chessai commented Sep 20, 2021

Hi @chessai, do you have any news about the review of this PR from the internal Japanese speaker?

Hi @udiu, sorry for the delay. The code received an internal review from Japanese speakers and I need to forward them along here (Normally, I would handle them myself internally, but my confidence that I can do so with Japanese is very low, so I'm going to forward them out externally)

@facebook-github-bot
Copy link

@chessai merged this pull request in dd70d80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants