`com.android.installreferrer` is called in the main thread which leads to ANR #1039

ddovod · 2022-01-17T15:30:49Z

Checklist before submitting a bug report

I've updated to the latest released version of the SDK
I've searched for existing Github issues
I've looked for existing answers on Stack Overflow, the Facebook Developer Community Forum and the Facebook Developers Group
I've read the Code of Conduct
This issue is not security related and can safely be disclosed publicly on GitHub

Java version

8

Android version

api 23+

Android SDK version

12.1

Installation platform & version

Gradle

Package

Other / I don't know

Goals

According to our investigations com.android.installreferrer can block the callers thread for a long time which in case of main thread leads to ANR. We call com.android.installreferrer from the background thread, it is safer and works just fine. Looks like fb sdk calls it from the main thread and we have a bunch of ANR reports that shows this case. Please consider moving com.android.installreferrer to the background thread. Thanks

Expected results

com.android.installreferrer is used in the background thread, no ANRs

Actual results

com.android.installreferrer is used in the main thread, ANRs

Steps to reproduce

No response

Code samples & details

Thread state: BLOCKED
android.os.BinderProxy.transactNative(BinderProxy.java:N)
android.os.BinderProxy.transact(BinderProxy.java:N)
e.c.a.a.a.XN(BaseProxy.java:N)
e.c.a.b.a.a$a$a.e(IGetInstallReferrerService.java:N)
com.android.installreferrer.api.InstallReferrerClientImpl.getInstallReferrer(InstallReferrerClientImpl.java:N)
com.facebook.internal.v$b.onInstallReferrerSetupFinished(InstallReferrerUtil.kt:N)
com.android.installreferrer.api.InstallReferrerClientImpl$InstallReferrerServiceConnection.onServiceConnected(InstallReferrerClientImpl.java:N)
android.app.LoadedApk$ServiceDispatcher.doConnected(LoadedApk.java:N)
android.app.LoadedApk$ServiceDispatcher$RunConnection.run(LoadedApk.java:N)
android.os.Handler.handleCallback(Handler.java:N)
android.os.Handler.dispatchMessage(Handler.java:N)
android.os.Looper.loop(Looper.java:N)
android.app.ActivityThread.main(ActivityThread.java:N)
java.lang.reflect.Method.invoke(Method.java:N)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:N)
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:N)

Edit: added a stacktrace

The text was updated successfully, but these errors were encountered:

Gell6 · 2022-02-23T15:34:17Z

Can you give me script attack for apk???

KulArtsiom · 2022-04-14T15:15:22Z

Hi guys!
I think ANR occur because you don't call the endConnection() on your InstallReferrerClient instance in tryConnectReferrerInfo function.

Information about it you can find in officially documentation

MrAugMyo · 2022-04-16T19:46:11Z

https://www.facebook.com/profile.php?id=100016695042794

Lok1n8 · 2023-03-13T05:47:10Z

same issue

Summary: Fix issue #1039 , we'll need to end the connection to avoid leaks and performance problems. https://developer.android.com/google/play/installreferrer/library#closing-connection Reviewed By: wx0165927473 Differential Revision: D44238528 fbshipit-source-id: 868b108305c2aa964c91c2456309e45fd06e0070

jasoncfpl · 2023-04-21T03:04:03Z

same issue

OldSlash · 2023-04-26T10:03:46Z

Issue is not fixed, we observe exact the same issue on FBSDK 16.0.1

EllieTellie · 2023-05-04T12:37:49Z

@KylinChang

29af39e This commit most likely does not fix this issue as it is simply closing it but other parts of the system can still be slow on the binder call.

The issue is triggered by the call: referrerClient.installReferrer on line 41 in https://github.com/facebook/facebook-android-sdk/blob/main/facebook-core/src/main/java/com/facebook/internal/InstallReferrerUtil.kt

If you look at the source, it's a bit tricky to follow because it is obfuscated, for InstallReferrerClientImpl you will find it does the following:
this(((InstallReferrerClientImpl)super).service.c(bundle));
This then calls Transact on the IBinder which causes the ANR.

From the ANR dashboard:
The latency of a Binder call is hard to predict. It can be affected not only by the complexity of the call itself, but also by intermittent factors such as system server lock contention. You should treat them as you would treat I/O calls, and avoid, if possible, making Binder calls in the main thread. If making a Binder call from the main thread is unavoidable, make sure to instrument and monitor such calls to detect slowness.

So this ends up being called on the main thread because onInstallReferrerSetupFinished callback happens on the main thread.

I'm not an Android or Kotlin developer so unfortunately I have no easy fixes here, but this referrerClient.installReferrer call should probably be async.

burak-cypher · 2023-07-28T13:15:54Z

Any updates on this? Getting exactly the same ANR on Play Console, not so rare. Using Unity SDK 15.1.0.

rampr · 2023-07-31T04:10:06Z

Having the same issue. Any updates here ?

umeriqbalbutt · 2023-08-21T08:58:58Z

Having the same issue any update on this ?

AshikRaj · 2023-10-13T18:15:07Z

We're on 16.2.0 and we're still seeing the same issue. Is there an update on when this will be fixed?

rubenwe · 2023-10-29T10:21:13Z

Same issue here. Come on folks, please fix this!

Holla-Chris · 2024-02-18T03:16:13Z

Same issue：

"main" tid=1 Native
#00 pc 0x0000000000070950 /apex/com.android.runtime/lib/bionic/libc.so (__ioctl+8)
#1 pc 0x000000000003f04f /apex/com.android.runtime/lib/bionic/libc.so (ioctl+26)
#2 pc 0x0000000000039f87 /system/lib/libbinder.so (android::IPCThreadState::talkWithDriver(bool)+238)
#3 pc 0x000000000003b07b /system/lib/libbinder.so (android::IPCThreadState::waitForResponse(android::Parcel*, int*)+86)
#4 pc 0x000000000003ae1f /system/lib/libbinder.so (android::IPCThreadState::transact(int, unsigned int, android::Parcel const&, android::Parcel*, unsigned int)+122)
#5 pc 0x00000000000356a7 /system/lib/libbinder.so (android::BpBinder::transact(unsigned int, android::Parcel const&, android::Parcel*, unsigned int)+98)
#6 pc 0x00000000000c7e53 /system/lib/libandroid_runtime.so (android_os_BinderProxy_transact(_JNIEnv*, _jobject*, int, _jobject*, _jobject*, int)+82)
at android.os.BinderProxy.transactNative (Native method)
at android.os.BinderProxy.transact (BinderProxy.java:559)
at com.google.android.a.a.b (a.java:2)
at com.google.android.finsky.externalreferrer.IGetInstallReferrerService$Stub$Proxy.c (IGetInstallReferrerService.java:3)
at com.android.installreferrer.api.InstallReferrerClientImpl.getInstallReferrer (InstallReferrerClientImpl.java:5)
at com.facebook.internal.InstallReferrerUtil$tryConnectReferrerInfo$installReferrerStateListener$1.onInstallReferrerSetupFinished (InstallReferrerUtil.kt:41)
at com.android.installreferrer.api.InstallReferrerClientImpl$InstallReferrerServiceConnection.onServiceConnected (InstallReferrerClientImpl.java:4)
at android.app.LoadedApk$ServiceDispatcher.doConnected (LoadedApk.java:1972)
at android.app.LoadedApk$ServiceDispatcher$RunConnection.run (LoadedApk.java:2004)
at android.os.Handler.handleCallback (Handler.java:938)
at android.os.Handler.dispatchMessage (Handler.java:99)
at android.os.Looper.loop (Looper.java:268)
at android.app.ActivityThread.main (ActivityThread.java:8016)
at java.lang.reflect.Method.invoke (Native method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:627)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:997)

jygao · 2024-02-26T03:04:41Z

same issue

manjeetcars24 · 2024-03-04T10:31:08Z

Any fix for this, we are also experiencing similar issue

alkanyunus · 2024-03-07T14:48:23Z

Also same here +1

zahid-abstron · 2024-03-28T05:52:20Z

at android.os.BinderProxy.transact (BinderProxy.java:571)
at com.google.android.finsky.externalreferrer.IGetInstallReferrerService$Stub$Proxy.getInstallReferrer (IGetInstallReferrerService.java:117)
at com.android.installreferrer.api.InstallReferrerClientImpl.getInstallReferrer (InstallReferrerClientImpl.java:187)
at com.facebook.internal.InstallReferrerUtil$tryConnectReferrerInfo$installReferrerStateListener$1.onInstallReferrerSetupFinished (InstallReferrerUtil.kt:41)
at com.android.installreferrer.api.InstallReferrerClientImpl$InstallReferrerServiceConnection.onServiceConnected (InstallReferrerClientImpl.java:222)
at android.app.LoadedApk$ServiceDispatcher.doConnected (LoadedApk.java:2095)
at android.app.LoadedApk$ServiceDispatcher$RunConnection.run (LoadedApk.java:2128)
at android.os.Handler.handleCallback (Handler.java:938)
at android.os.Handler.dispatchMessage (Handler.java:99)
at android.os.Looper.loopOnce (Looper.java:201)
at android.os.Looper.loop (Looper.java:288)
at android.app.ActivityThread.main (ActivityThread.java:7881)
at java.lang.reflect.Method.invoke (Native method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:568)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1045)

Same Issue here,

zhaowhao · 2024-04-02T08:25:35Z

"main" tid=1 Native
  #00  pc 0x00000000000c9da8  /apex/com.android.runtime/lib64/bionic/libc.so (__ioctl+8)
  #01  pc 0x0000000000083888  /apex/com.android.runtime/lib64/bionic/libc.so (ioctl+156)
  #02  pc 0x0000000000056044  /system/lib64/libbinder.so (android::IPCThreadState::talkWithDriver(bool)+292)
  #03  pc 0x0000000000057280  /system/lib64/libbinder.so (android::IPCThreadState::waitForResponse(android::Parcel*, int*)+64)
  #04  pc 0x0000000000056fc4  /system/lib64/libbinder.so (android::IPCThreadState::transact(int, unsigned int, android::Parcel const&, android::Parcel*, unsigned int)+224)
  #05  pc 0x000000000004eb18  /system/lib64/libbinder.so (android::BpBinder::transact(unsigned int, android::Parcel const&, android::Parcel*, unsigned int)+312)
  #06  pc 0x0000000000169a84  /system/lib64/libandroid_runtime.so (android_os_BinderProxy_transact(_JNIEnv*, _jobject*, int, _jobject*, _jobject*, int)+400)
  at android.os.BinderProxy.transactNative (Native method)
  at android.os.BinderProxy.transact (BinderProxy.java:635)
  at com.google.android.finsky.externalreferrer.IGetInstallReferrerService$Stub$Proxy.getInstallReferrer (IGetInstallReferrerService.java:117)
  at com.android.installreferrer.api.InstallReferrerClientImpl.getInstallReferrer (InstallReferrerClientImpl.java:187)
  at com.facebook.internal.InstallReferrerUtil$tryConnectReferrerInfo$installReferrerStateListener$1.onInstallReferrerSetupFinished (InstallReferrerUtil.kt:41)
  at com.android.installreferrer.api.InstallReferrerClientImpl$InstallReferrerServiceConnection.onServiceConnected (InstallReferrerClientImpl.java:222)
  at android.app.LoadedApk$ServiceDispatcher.doConnected (LoadedApk.java:2186)
  at android.app.LoadedApk$ServiceDispatcher$RunConnection.run (LoadedApk.java:2219)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:233)
  at android.os.Looper.loop (Looper.java:344)
  at android.app.ActivityThread.main (ActivityThread.java:8212)
  at java.lang.reflect.Method.invoke (Native method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:584)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1034)

Same here.We've encountered the same ANR issue on Google Play Console. Does anyone have a solution for this?

Ceikry · 2024-04-12T17:56:48Z

Also having the same issue here. It would be great if this was fixed, as it currently accounts for 30% of our ANRs.

ddovod added bug needs-triage labels Jan 17, 2022

dreamcodestudio mentioned this issue Feb 9, 2023

InstallReferrerUtil.kt com.facebook.internal.InstallReferrerUtil$tryConnectReferrerInfo facebook/facebook-sdk-for-unity#672

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`com.android.installreferrer` is called in the main thread which leads to ANR #1039

`com.android.installreferrer` is called in the main thread which leads to ANR #1039

ddovod commented Jan 17, 2022 •

edited

Gell6 commented Feb 23, 2022

KulArtsiom commented Apr 14, 2022 •

edited

MrAugMyo commented Apr 16, 2022

Lok1n8 commented Mar 13, 2023

jasoncfpl commented Apr 21, 2023

OldSlash commented Apr 26, 2023

EllieTellie commented May 4, 2023 •

edited

burak-cypher commented Jul 28, 2023

rampr commented Jul 31, 2023

umeriqbalbutt commented Aug 21, 2023

AshikRaj commented Oct 13, 2023

rubenwe commented Oct 29, 2023

Holla-Chris commented Feb 18, 2024

jygao commented Feb 26, 2024

manjeetcars24 commented Mar 4, 2024

alkanyunus commented Mar 7, 2024

zahid-abstron commented Mar 28, 2024

zhaowhao commented Apr 2, 2024

Ceikry commented Apr 12, 2024

com.android.installreferrer is called in the main thread which leads to ANR #1039

com.android.installreferrer is called in the main thread which leads to ANR #1039

Comments

ddovod commented Jan 17, 2022 • edited

Checklist before submitting a bug report

Java version

Android version

Android SDK version

Installation platform & version

Package

Goals

Expected results

Actual results

Steps to reproduce

Code samples & details

Gell6 commented Feb 23, 2022

KulArtsiom commented Apr 14, 2022 • edited

MrAugMyo commented Apr 16, 2022

Lok1n8 commented Mar 13, 2023

jasoncfpl commented Apr 21, 2023

OldSlash commented Apr 26, 2023

EllieTellie commented May 4, 2023 • edited

burak-cypher commented Jul 28, 2023

rampr commented Jul 31, 2023

umeriqbalbutt commented Aug 21, 2023

AshikRaj commented Oct 13, 2023

rubenwe commented Oct 29, 2023

Holla-Chris commented Feb 18, 2024

jygao commented Feb 26, 2024

manjeetcars24 commented Mar 4, 2024

alkanyunus commented Mar 7, 2024

zahid-abstron commented Mar 28, 2024

zhaowhao commented Apr 2, 2024

Ceikry commented Apr 12, 2024

`com.android.installreferrer` is called in the main thread which leads to ANR #1039

`com.android.installreferrer` is called in the main thread which leads to ANR #1039

ddovod commented Jan 17, 2022 •

edited

KulArtsiom commented Apr 14, 2022 •

edited

EllieTellie commented May 4, 2023 •

edited