Support applicationId prefixed with "fb" #435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to have opportunity to force applicationId to be string. Otherwise if you specify applicationId directly through Android manifest (not through constant in strings.xml file) it will overflow to 32-bit int instead of string. I suggest to support also applicationIds with prefix "fb" which will ensure that it will be parsed to string correctly. It will be also similar to CFBundleURLSchemes in iOS version of SDK which is also prefixed by "fb".