-added missing CREATOR to parcelable class AppInviteContent #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiese
added a commit
that referenced
this pull request
Aug 11, 2015
-added missing CREATOR to parcelable class AppInviteContent
|
Nice find! Looks like this is also missing in some other places. I'll merge your fix for this and also fix up some other places for our next release. |
|
Yeah I was looking also to other classes (like AppGroupCreationContent, GameRequestContent, ...) and wanted to ask you if we should update them also. But I wanted to wait until you approve one to open discussion. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this class in Activity and it crashed my application because it is missing CREATOR http://developer.android.com/reference/android/os/Parcelable.html.