Fix bug:sdkInitialize method set availableVersions not null,but empty then facebook app cannot be launched. #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, then facebook app cannot be launched sometimes.
There was a problem hiding this comment.
@jingping2015 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When facebook app is not alive, sdk cannot fetch ProtocolVersions from faceboook app using ContentProvider. (Because many Chinese smart phone disallow application started by other app.)
So when launching sharing app, then lanunch the facebook app, shaing app cannot start facebook app when sharing at the first time.
This is becasue FacebookSdk.sdkInitialize method makes availableVersions not null, but empty. So I add this to fix this bug.