Resolve more PHP 8.1 Deprecations #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
natewiebe13
force-pushed
the
resolve-php-deprecation
branch
from
8d4832b
to
0082755
Compare
natewiebe13
changed the title
|
@stcheng any chance we could get some movement on this one? |
|
@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/facebook-php-business-sdk
that referenced
this pull request
Nov 29, 2022
Summary: Fixes #565 This PR along with facebook/facebook-business-sdk-codegen#50 should resolve the remaining PHP 8.1 deprecations. Pull Request resolved: #566 Differential Revision: D41485922 Pulled By: stcheng fbshipit-source-id: 27275fe1e93c8f6604d1e9019a12140c90bfd735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #40
Checklist
Pull Request Details
Resolves php 8.1 deprecation from the closed PR above.
Further to this, commit 7a99f03 which was to supersede the PR does not implement return types for all of the cases that PR covered. This adds the remaining return types for functions implementing interfaces.