Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Interactive inside paragraph #139

Closed
basarkar opened this issue Jul 8, 2016 · 5 comments
Closed

Interactive inside paragraph #139

basarkar opened this issue Jul 8, 2016 · 5 comments
Assignees

Comments

@basarkar
Copy link

basarkar commented Jul 8, 2016

This is not an issue rather a feature request.

@everton-rosario
Copy link
Contributor

@basarkar Thanks for contributing.

Can you provide more details about this?
Try to provide who your html markup is, and then we can check how we can implement this.
Please reopen when getting it more detailed, please.

@basarkar
Copy link
Author

basarkar commented Jul 8, 2016

From:
<p>lorem ipsum<iframe src="http://www.google.com"></iframe>Hello world</p>
To:
<p>lorem ipsum</p>
<figure class="op-interactive">
        <iframe src="http://www.google.com" class="no-margin"></iframe>
 </figure>
<p>Hello world</p>

@everton-rosario
Copy link
Contributor

@basarkar Is it possible for you to have it in separated paragraphs before sending to Transformer?

something like:

<p>lorem ipsum</p>
<iframe src="http://www.google.com">
<p>Hello world</p>

@basarkar
Copy link
Author

basarkar commented Jul 9, 2016

I guess I have to do dom manipulation before sending it to the transformer. If you want then I can try to create a rule class like InteractiveInsideParagraphRule.php same as like ImageInsideParagraphRule.php

@basarkar
Copy link
Author

Thanks @everton-rosario

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants