Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Latest Laravel requires other version of Symfony's css-selector #171

Closed
ronaldgj opened this issue Oct 10, 2016 · 4 comments
Closed

Latest Laravel requires other version of Symfony's css-selector #171

ronaldgj opened this issue Oct 10, 2016 · 4 comments
Assignees
Labels

Comments

@ronaldgj
Copy link

Steps required to reproduce the problem

  1. Require version 3.* of symfony's css-selector

Expected Result

  • No errors when installing this SDK with composer in Laravel

Actual Result

  • Errors, because Laravel needs version 3.* and Facebook 2.8.
@everton-rosario
Copy link
Contributor

everton-rosario commented Oct 10, 2016

@ronaldgj Thanks for flagging this.
So far we are not aiming to move to the newest version of CSS selector because it requires PHP > 5.5.+ and we still need to have it compatible to PHP >= 5.4.

What I recommend you to do is:

  • Checkout the master version of this component

  • Change composer.json to set required version of the CSS Selector:

    "require": {
          "php": "^5.4 || ^7.0",
          "symfony/css-selector": "3.*",
          "facebook/graph-sdk": "~5.0",
          "apache/log4php": "2.3.0"
      }
    
  • Run composer update then composer install

It will build a version compatible as you need.

Thanks for flagging this and let me know if that procedure works for you.

@ronaldgj
Copy link
Author

For now I changed the composer.json of Laravel back to 2.8. I saw Laravel only uses it for 'tests'. For now I'm not using that so this is a temporary solution for me. I'll will try this soon and let you know if it worked!

Thank you for your respons!

@kamranata
Copy link

Hi @everton-rosario. I saw you added to your composer.json
"php": "^5.4 || ^5.6 || ^7", "symfony/css-selector": "^2.8 || ^3.1 || ^4.1",

But when I use composer require facebook/facebook-instant-articles-sdk-php composer uses another json file. "php": "^5.4 || ^7.0", "symfony/css-selector": "^2.8 || ^3.0",

Can you fix this?

@everton-rosario
Copy link
Contributor

So you're mentioning a conflict with the symfony/css-selector. Can you propose a PR so I can understand better what you are proposing?

Thanks for reporting it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants