Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: This type exists to make it easier to work with the Graph API to provide test user accounts. A few reasons to get rid of this: 1. It's shipped as production code but really just exists for setting up integration tests. This is clearly wrong. 2. It's generally not the SDKs job to maintain specific calls to endpoints (outside of a few specific use cases such as login and app events). CoreKit should only implement the specific graph requests that are required to enable a user to form their own graph requests. 3. This is easily implemented by anyone who is currently using it. The internal CoreKit import can be replaced by ``` #import "FBSDKCoreKit_Basics.h" #import "FBSDKCoreKit.h" ``` 4. Graph API usage suggests that barely anyone is using this type. Effectively 0% usage. Reviewed By: KylinChang Differential Revision: D26915949 fbshipit-source-id: 9218d23f04c6008d151a142887fbcf1d0ce48ce5
- Loading branch information