-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rolling up a few pull requests -- thanks!
Summary: This diff rolls-up the following pull request - * 449 - SevaUA * 446, 445 - adamvduke * 435 - deyton Test Plan: manual, used hackbook to exercise impacted code Reviewers: yariv, mmarucheck, vijaye, caabernathy Reviewed By: vijaye CC: gregschechte, selekman Differential Revision: https://phabricator.fb.com/D448786 Task ID: 1021338, 981999
- Loading branch information
Showing
4 changed files
with
23 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5077944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing an infinite recursion by checking _requestExtendingAccessToken instead of the BOOL. Request is never returned from openUrl to be used. Previously the BOOL was getting set YES once and that ensures that extendAccessToken gets runs once.
5077944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment! I put it back to using the bool, to determine whether or not to short-circuit.