-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor to init session delegate in Facebook.m constructor
Summary: The change basically just sets the session delegate in the constructor so it's available when handleOpenUrl is called. Test Plan: Ran the DemoApp and ensured SSO still works. Reviewed By: toddkrabach Reviewers: seshadri, leon, atishm, toddkrabach, lshepard, caabernathy Differential Revision: 297414 Task ID: 653835
- Loading branch information
Showing
3 changed files
with
13 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91f2564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the documentation/README when you make a change in the API this significant would be very helpful. :D
91f2564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
91f2564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@typeoneerror - my apologies, the update to the documentation is almost complete and will be available ASAP. Please feel free to contact me directly if there are any issues/questions that are blocking your development efforts and you need resolved urgently.
91f2564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logout: should probably change too then. Otherwise, calling logout: will change the sessionDelegate.
91f2564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
91f2564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pulled the latest changes and am regretting it due to this API change, that wasn't mentioned anywhere. Didn't take too much reading of the sources / changeset to find out what to do to fix things, but the doc has been out of date for quite a while now...