Rename the current isAutoLogAppEventsEnabled to isAutoLogAppEventsEna…

…bledOnClientSide

Summary: Introduce a new internal client side only flag during the transition. The original `isAutoLogAppEventsEnabled` will be delegated to `isAutoLogAppEventsEnabledOnClientSide`. In the next diff, we will be adding new getter and setter for the `isAutoLogAppEventsEnabled` flag.

Reviewed By: dreamolight

Differential Revision: D51330511

fbshipit-source-id: cd63649372861fcdf9d06e0ecd60acae3753490f

FBSDKCoreKit/FBSDKCoreKit/Settings+Logging.swift

@@ -34,13 +34,6 @@ extension Settings {
    @warning INTERNAL - DO NOT USE
    */
   public func logWarnings() {
-    // Log warnings for App Event Flags
-    // swiftformat:disable:next redundantSelf
-    if self.infoDictionaryProvider?
-      .fb_object(forInfoDictionaryKey: PersistenceKey.isAutoLogAppEventsEnabled.rawValue) == nil {
-      print(AppEventFlagWarningMessages.isAutoLogAppEventsEnabledNotSet)
-    }
-
     // swiftformat:disable:next redundantSelf
     if self.infoDictionaryProvider?
       .fb_object(forInfoDictionaryKey: PersistenceKey.isAdvertiserIDCollectionEnabled.rawValue) == nil {
@@ -80,7 +73,7 @@ extension Settings {
     var initialBitmask = 0
     var usageBitmask = 0
     let bits: [(key: PersistenceKey, defaultValue: Bool)] = [
-      (key: .isAutoLogAppEventsEnabled, defaultValue: true),
+      (key: .isAutoLogAppEventsEnabledLocally, defaultValue: true),
       (key: .isAdvertiserIDCollectionEnabled, defaultValue: true),
     ]
 

FBSDKCoreKit/FBSDKCoreKit/Settings+PersistedProperties.swift

@@ -60,9 +60,9 @@ extension Settings {
     let backingKeyPath: ReferenceWritableKeyPath<Settings, Bool?> // swiftlint:disable:this discouraged_optional_boolean
     let defaultValue: Bool
 
-    static let isAutoLogAppEventsEnabled = Self(
-      persistenceKey: .isAutoLogAppEventsEnabled,
-      backingKeyPath: \._isAutoLogAppEventsEnabled,
+    static let isAutoLogAppEventsEnabledLocally = Self(
+      persistenceKey: .isAutoLogAppEventsEnabledLocally,
+      backingKeyPath: \._isAutoLogAppEventsEnabledLocally,
       defaultValue: true
     )
 

FBSDKCoreKit/FBSDKCoreKit/Settings+PersistenceKey.swift

@@ -12,7 +12,7 @@ extension Settings {
     case clientToken = "FacebookClientToken"
     case displayName = "FacebookDisplayName"
     case domainPart = "FacebookDomainPart"
-    case isAutoLogAppEventsEnabled = "FacebookAutoLogAppEventsEnabled"
+    case isAutoLogAppEventsEnabledLocally = "FacebookAutoLogAppEventsEnabled"
     case isAdvertiserIDCollectionEnabled = "FacebookAdvertiserIDCollectionEnabled"
     case isCodelessDebugLogEnabled = "FacebookCodelessDebugLogEnabled"
     case loggingBehaviors = "FacebookLoggingBehavior"

FBSDKCoreKit/FBSDKCoreKit/Settings.swift

@@ -80,12 +80,22 @@ public final class Settings: NSObject, SettingsProtocol, SettingsLogging, _Clien
    The default value is `true`.
    */
   public var isAutoLogAppEventsEnabled: Bool {
-    get { getPersistedBooleanProperty(.isAutoLogAppEventsEnabled) }
-    set { setPersistedBooleanProperty(.isAutoLogAppEventsEnabled, to: newValue) }
+    get { isAutoLogAppEventsEnabledLocally }
+    set { isAutoLogAppEventsEnabledLocally = newValue }
+  }
+
+  /**
+   Controls the automatic logging of basic app events on the client side such as `activateApp` and `deactivateApp`.
+
+   The default value is `true`.
+   */
+  internal var isAutoLogAppEventsEnabledLocally: Bool {
+    get { getPersistedBooleanProperty(.isAutoLogAppEventsEnabledLocally) }
+    set { setPersistedBooleanProperty(.isAutoLogAppEventsEnabledLocally, to: newValue) }
   }
 
   // swiftlint:disable:next identifier_name discouraged_optional_boolean
-  var _isAutoLogAppEventsEnabled: Bool?
+  internal var _isAutoLogAppEventsEnabledLocally: Bool?
 
   /**
    Controls the `fb_codeless_debug` logging event.