Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App suddenly crashing on startup in production due to FBSDKRestrictiveDataFilterManager.m #1427

Closed
4 of 5 tasks
nicklocking opened this issue Jul 10, 2020 · 130 comments
Closed
4 of 5 tasks

App suddenly crashing on startup in production due to FBSDKRestrictiveDataFilterManager.m #1427

nicklocking opened this issue Jul 10, 2020 · 130 comments

Comments

@nicklocking
Copy link

nicklocking commented Jul 10, 2020 •
edited
Loading

Checklist

Environment

Describe your dev environment here, giving as many details as possible. If you have them, make sure to include:

Production. Facebook SDK 5.0.2.

Goals

What do you want to achieve?

My company's app to not crash in production.

Expected Results

What do you expect to happen?

My app to work properly in production.

Actual Results

What actually happened? Can you provide a stack trace?

The app crashes on open, because of Facebook's SDK, starting at 10:53PM PST. Seems to be happening for 100% of users. 1400 crashes in the last 16 minutes.

FBSDKRestrictiveDataFilterManager.m - Line 108
+[FBSDKRestrictiveDataFilterManager updateFilters:restrictiveParams:] + 108

Steps to Reproduce

What are the steps necessary to reproduce this issue?

Open our app, Pray.com.
@agam-mahajan-swiggy
Copy link

agam-mahajan-swiggy commented Jul 10, 2020 •
edited
Loading

Happening for my App also. 'FBSDKCoreKit' , '5.1.1' for all the users.

@ethanhuang13
Copy link

Happening on my app. tvOS with FBSDKCoreKit v5.8.0.
(However the iOS app with the same SDK version is not affected.)

@furthergo
Copy link

APP using FBSDKCoreKit v5.0.2 is crash, which using FBSDKCoreKit v5.4.1 is OK

@sekitaka
Copy link

APP using FBSDKCoreKit v5.0.2 is crash, which using FBSDKCoreKit v7.1.1 is OK

@PrLion
Copy link

PrLion commented Jul 10, 2020

Please fix this ASAP.

@agam-mahajan-swiggy
Copy link

Upgraded FBSDKCoreKit to 7.1.1. Working fine now
For existing users, Had a kill switch to disable SDK

@PrLion
Copy link

PrLion commented Jul 10, 2020

Upgraded FBSDKCoreKit to 7.1.1. Working fine now
For existing users, Had a kill switch to disable SDK

Did you solve it?

@agam-mahajan-swiggy
Copy link

I think the issue is with the older SDKs. I'm not exactly sure what is causing the issue.
After updating to the latest SDK, it's not crashing

Before also a discussion happened on this crash.
#1374

@PrLion
Copy link

PrLion commented Jul 10, 2020

I think the issue is with the older SDKs. I'm not exactly sure what is causing the issue.
After updating to the latest SDK, it's not crashing

Before also a discussion happened on this crash.
#1374

Yep. But if app in store we can't solve it ourself. Only update.

@puneet1106
Copy link

puneet1106 commented Jul 10, 2020 •
edited
Loading

For FBSDKCoreKit v5.0.2 facing this issue. Please fix this ASAP.

@agam-mahajan-swiggy
Copy link

agam-mahajan-swiggy commented Jul 10, 2020 •
edited
Loading

@PrLion yeah. For my app on App Store, it worked because of the kill switch which is controlled remotely. I disabled SDK when got crash alert.

Now Either we have to wait for the FB team to reply and fix this or you can meanwhile upgrade to latest SDK (try 7.1.1) and request for expedite release to the Apple team.

Also, add some kill switch for this SDK so that this kind of situation doesn't come again.

@PrLion
Copy link

PrLion commented Jul 10, 2020 •
edited
Loading

@PrLion yeah. For my app on App Store, it worked because of the kill switch which is controlled remotely.

Now Either we have to wait for the FB team to reply and fix this or you can meanwhile upgrade and request for expedite release to the Apple team.

thx. Can you tell how can I do this one too?

@Garima0812
Copy link

App is getting crashed since 11:45 in the morning due to the exception in FBSDK . Please resolve it as soon as possible .

@agam-mahajan-swiggy
Copy link

agam-mahajan-swiggy commented Jul 10, 2020 •
edited
Loading

@PrLion After submitting app for review
Go to this link https://developer.apple.com/contact/app-store/?topic=expedite and fill the necessary information.
Mention the crash and the fix.

@PrLion
Copy link

PrLion commented Jul 10, 2020

@PrLion After submitting app for review
Go to this link https://developer.apple.com/contact/app-store/?topic=expedite and fill the necessary information.
Mention the crash and the fix.

Thank you)

@OneManMobile
Copy link

Is there a timeline for the rollout of a fix @joesus ?

@wangjunhua1
Copy link

The old version suddenly appeared a lot of crashes today
[FBSDKRestrictiveDataFilterManager updateFilters:restrictiveParams:]
image

@alainnguyen
Copy link

Same here on our iOS App on Live users, using FBSDK 5.1.1.
Please, fix the regression ASAP.

@matt-aitken
Copy link

Same here. I believe this issue also happened on May 7!!

@rom4ikq
Copy link

rom4ikq commented Jul 10, 2020

Same here. Using FBSDK 5.0.2

@danbus
Copy link

danbus commented Jul 10, 2020

The same problem, please fix it as soon as possible, affecting all users

@samh-depop
Copy link

We are using 5.2.3 and having the same crash.
This is crashing the app for all our users in productions.

Can anyone help on this?

@JamesSawley
Copy link

Same problem on 5.11

@IainS1986
Copy link

Same issue with SDK 5.0.2 (Xamarin package Xamarin.Facebook.iOS 5.0.2 etc)

Upgrading to SDK 5.12.0 (Xamarin package(s) Xamarin.Facebook.iOS 5.12.0 etc) seemed to resolve the issue.

@PavloNovak
Copy link

Same 5.6.0

@th3hamm0r
Copy link

Just tested a minor upgrade from 5.0 to 5.15.0, it worked for a couple of app-starts, but then started crashing again (so the SDK seems to update itself in some ways).
So you will probably need a higher version, but I cannot tell at the moment, if that fixes the issue...

Related: #1373 (comment)

@kopfnick
Copy link

Multiple of our apps crashing for us, new releases are not an option. Spotify is also down...

@esam091
Copy link

esam091 commented Jul 10, 2020

All essential apps in my country crashes ☹️

@tecbot
Copy link

tecbot commented Jul 10, 2020

Second time this year, great

@guptameet
Copy link

FBKMKB

@traceyhemp12
Copy link

traceyhemp12 commented Jul 10, 2020 •
edited
Loading

Glad there is a fix

@JCBird1012 JCBird1012 mentioned this issue Jul 10, 2020
Closed
@ghost
Copy link

ghost commented Jul 10, 2020

Is there a postmortem from the last time? I am trying to find whether Facebook released or has plans to release an SDK update to prevent this class of issue, but all I have found so far are:

Buildstarted added a commit to Buildstarted/linksfordevs that referenced this issue Jul 10, 2020
@Buildstarted
Updating: 7/10/2020 2:00:00 PM
480223d 
 1. Added: App suddenly crashing on startup in production due to FBSDKRestrictiveDataFilterManager.m · Issue #1427 · facebook/facebook-ios-sdk
    (facebook/facebook-ios-sdk#1427)
 2. Added: Start Your Career as a Frontend Developer with Scrimba
    (https://www.youtube.com/watch?v=QdeV4qhK1KU)
@ryankearney
Copy link

starting at 10:53PM PST.

Did you mean 10:53 PDT? Pacific Standard Time isn't currently observed. Pacific Daylight Time is the correct timezone to use. There is a 1 hour difference between the two.

@joesus
Copy link
Contributor

joesus commented Jul 10, 2020

Earlier today, a code change triggered crashes for some iOS apps using the Facebook SDK. We identified the issue quickly and resolved it. We apologize for any inconvenience.

@joesus joesus closed this as completed Jul 10, 2020
This was referenced Jul 10, 2020
Closed
Closed
Closed
Closed
@scf4
Copy link

scf4 commented Jul 10, 2020

Thanks for that quick fix guys! I’m looking forward to Apple’s more permanent solution :)

@joesus joesus mentioned this issue Jul 10, 2020
Closed
@moleki
Copy link

moleki commented Jul 10, 2020

Are you guys going to do something to prevent this issue from happening a 3rd time? Or should I start a petition for FB to start having a proper QA?

@joesus joesus mentioned this issue Jul 10, 2020
Closed
@marcusmotill
Copy link

@moleki Facebook is a cancerous dumpster fire nobody wants to work there so we get third rate development

@vincentclee
Copy link

NextDNS is showing a lookup on graph.facebook.com when opening up Waze.

Blocking that should do the trick.

@brandonros
Copy link

@moleki Facebook is a cancerous dumpster fire nobody wants to work there so we get third rate development

is that true? i'm pretty sure they pay like... $300k-$1m/yr...

@andrewpbrett andrewpbrett mentioned this issue Jul 10, 2020
Closed
@abhay8nitt
Copy link

FBSDK sounds as F-BSDK

@rubyFeedback
Copy link

SamJakob I believe the emotional aspect is not the one of primary interest here; the engineering approach is that even when you dislike a company or a team of developers xyz (let's assume this for the moment), if something is a bug (let's assume it is as well), then the proper engineering point of view should be to fix the bug, or at the least find means to mitigate or work around it, if fixing is not possible for whatever the reason (right now). I myself reported bugs to projects I dislike or disagree with, where there, again, were several reasons as to why that was done. I find nothing wrong with reporting bugs.

@chronikum
Copy link

Thanks for the fix. But you should consider improving your testing/review process and reflect about what happened.

@joesus joesus mentioned this issue Jul 10, 2020
Closed
@enahs
Copy link

enahs commented Jul 10, 2020

SamJakob I believe the emotional aspect is not the one of primary interest here; the engineering approach is that even when you dislike a company or a team of developers xyz (let's assume this for the moment), if something is a bug (let's assume it is as well), then the proper engineering point of view should be to fix the bug, or at the least find means to mitigate or work around it, if fixing is not possible for whatever the reason (right now). I myself reported bugs to projects I dislike or disagree with, where there, again, were several reasons as to why that was done. I find nothing wrong with reporting bugs.

Well of course I agree that Quality Assurance needs to be improved (and these bugs need to be mitigated) but I maintain that it's hard to argue calling Facebook a "cancerous dumpster fire" is constructive, no matter how true it may be.

cancer (noun): a practice or phenomenon perceived to be evil or destructive and hard to contain or eradicate.
dumpster fire (noun): a chaotic or disastrously mishandled situation.

I'd say this about meets the requirements, wouldn't you?

@dancojocaru2000
Copy link

dancojocaru2000 commented Jul 11, 2020 •
edited
Loading

Thanks for the fix. But you should consider improving your testing/review process and reflect about what happened.

They never do unless it results in them getting less data.

Facebook seems to be only interested in harvesting more data, hence why they force the use of a privacy invading SDK in the first place when most people just want login.

The only time they'll improve QA is if not doing so will lead to people leaving and them not getting as much data anymore, considering this is the second time a Facebook SDK issue affected a lot of apps.

@siddheshc27
Copy link

I faced this crashing issue with v7.1.1 & v7.0.1 as well, #1435

Is there any new update available which contains fix for crashing issue ??

@archywillhe
Copy link

Great! We have just witness how much power FB has over the app economy :D

@joesus joesus mentioned this issue Jul 13, 2020
Closed
@crazymanish
Copy link

In case, someone looking for a solution: #1431 (comment)

@vg-identance vg-identance mentioned this issue Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests