Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Catalyst: Facebook SDK 8.2.0 won't compile as an SPM dependency (whereas 6.5.1 works) #1577

Closed
5 tasks done
thuss opened this issue Nov 14, 2020 · 1 comment
Closed
5 tasks done

Comments

@thuss
Copy link

thuss commented Nov 14, 2020

Checklist

Environment

Describe your dev environment here, giving as many details as possible. If you have them, make sure to include:

  • Xcode Version: 11.7 (also tested latest 12.2, same issue)
  • Swift Version: 5.2 (also tested latest 5.3.1, same issue)
  • Installation Platform & Verison: Swift Package Manager

Goals

The Facebook SDK 6.5.1 works fine in iOS/Catalyst projects as a Swift Package Manager dependency whereas 8.2.0 will compile for iOS but not Catalyst.

Expected Results

To be able to include the Facebook SDK as a Swift Packager Manager dependency in Mac Catalyst apps.

Actual Results

It fails to compile with the error FBSDKCoreKit/FBSDKCoreKit.h file not found in FBSDKCoreKitImport.h

Steps to Reproduce

  1. Create a new iOS app with Mac catalyst support (you can use Xcode 11.7 or the latest 12.2, it doesn't matter. Run it on iOS and Mac and it works fine.
  2. Add the 8.2.0 Facebook SDK as a Swift Package Manager dependency: Screen Shot 2020-11-13 at 5 10 05 PM
  3. When running the iOS target it builds and runs fine but when running the Mac Catalyst target it can't compile the Facebook SDK
  4. If you downgrade the dependency to the Facebook SDK 6.5.1 it works on both iOS and Mac Catalyst

Code Samples & Details

Screenshot of the issue: Screen Shot 2020-11-13 at 5 00 16 PM

Sample project for Xcode 11.7 (but same issue occurs with Xcode 12.2)
CatalystTest.zip

joesus added a commit to joesus/facebook-ios-sdk that referenced this issue Nov 18, 2020
Summary:
A required macro was not available for macOS platform.

Fixes: facebook#1577

Differential Revision: D25064406

fbshipit-source-id: e6042725b964fc8529946fade1cd19890ded314a
@joesus
Copy link
Contributor

joesus commented Nov 18, 2020

Thanks for calling this out! Will try and get this into the next release! Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants