Stop shadowing dataTask method on NSURLSession #1721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This was causing issues in calling the `dataTask(with: URL)` method on instances of `NSURLSession`. Moves the default conformance to the places that use it so it's not in the header for Basics which is public when using CocoaPods. Should resolve: facebook#1643 and facebook#1718 Differential Revision: D27920718 fbshipit-source-id: 58f88e9489ded6db001b5c4f179538025e604236
|
This pull request was exported from Phabricator. Differential Revision: D27920718 |
|
This pull request has been merged in abd3f6c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was causing issues in calling the
dataTask(with: URL)method on instances ofNSURLSession.Moves the default conformance to the places that use it so it's not in the header for Basics which is public when using CocoaPods.
Should resolve: #1643 and #1718
Differential Revision: D27920718