Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java 1.7 support? #61

Closed
chrisptang opened this issue Nov 16, 2016 · 5 comments
Closed

java 1.7 support? #61

chrisptang opened this issue Nov 16, 2016 · 5 comments

Comments

@chrisptang
Copy link

Hi, it seems like current package only supports java 1.8+, while some of our exists projects are using 1.7 or older. It requires a lot of extra works to upgrade all our projects to java 1.8. Would you plan to support java1.7 in the future?

@locspin
Copy link

locspin commented Nov 16, 2016

Seconded. Only supporting Java 1.8+ requires similar changes in our
ecosystem. We are manually calling the API until that is resolved, which is
a pain.

On Nov 15, 2016 7:41 PM, "Peng Tang" notifications@github.com wrote:

Hi, it seems like current package only supports java 1.8+, while some of
our exists projects are using 1.7 or older. It requires a lot of extra
works to upgrade all our projects to java 1.8. Would you plan to support
java1.7 in the future?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#61, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVJn0vZWAsiLflBFrK_wHgj4Q75Z0ngyks5q-nt8gaJpZM4KzUgo
.

@chrisptang
Copy link
Author

Hi @locspin
I just build a jdk1.7 version: https://github.com/chrisptang/facebook-java-ads-sdk/tree/master/target

Main changes:

Enjoy.

@lintaocui
Copy link

Hi @chrisptang @locspin , thank you for reporting the issue. Support Java 1.7 sounds reasonable, given there are already two asks for it. We are keeping this issue tracked.

@JiamingFB
Copy link
Contributor

Java 7 is now supported in latest release

@chrisptang
Copy link
Author

Sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants