Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdVideo.getThumbnails throws "Error: No endpoint specified for the target edge." #35

Closed
thierryjacoel opened this issue Mar 15, 2018 · 5 comments
Labels

Comments

@thierryjacoel
Copy link

thierryjacoel commented Mar 15, 2018

The method getThumbnails is defined as follow:

getThumbnails (fields: Object, params: Object): Cursor {
    return this.getEdge(VideoThumbnail, fields, params, 'thumbnails');
  }

The call to getEdge misses the parameter fetchFirstPage in 4th position, thus having the parameter endpoint not provided, which ends up in an exception raised when creating the Cursor.

Replacing the definition of getThumbnails with

getThumbnails(fields: Object, params: Object): Cursor {
    var fetchFirstPage = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
    return this.getEdge(adsSdk.VideoThumbnail, fields, params, fetchFirstPage, 'thumbnails');
}

fixes the problem.

@codytwinton
Copy link
Contributor

It seems like this issue has been open for more than a few months now. We have made many changes in the SDK since then, including releasing a new version. If you can repro your specific issue with the latest version of the SDK, please create a new issue or comment here with further details.

@Dai1678
Copy link

Dai1678 commented Aug 20, 2018

I am using the latest version, but this problem has not been resolved in the past.

I think this 1code is necessary for this function.
var fetchFirstPage = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;

I tried @thierryjacoel suggested code in my local environment and it worked.

@codytwinton please fixes the problem.

@codytwinton
Copy link
Contributor

Thanks for opening #76, but I'm just going to reopen this issue.

@codytwinton codytwinton reopened this Aug 20, 2018
@stale
Copy link

stale bot commented Jan 14, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jan 14, 2020
@stale
Copy link

stale bot commented Jan 21, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jan 21, 2020
supasate added a commit to supasate/facebook-nodejs-ads-sdk that referenced this issue Nov 3, 2021
Summary:
Pull Request resolved: facebook/facebook-business-sdk-codegen#35

1. `types_first` has been deprecated (https://flow.org/en/docs/config/options/). It produces an error `".flowconfig: Unsupported option specified! (types_first)"`. So, this diff removes it from `.flowconfig`

2. After removing it, there are a lot of flow errors, so, this diff fixes those flow errors.

Reviewed By: jingping2015

Differential Revision: D32056933

fbshipit-source-id: 24f3f2f1c68a1572cd2bcc0972b5b49b73372879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants