Remove types_first from .flowconfig and fix flow errors #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 1. `types_first` has been deprecated (https://flow.org/en/docs/config/options/). It produces an error `".flowconfig: Unsupported option specified! (types_first)"`. So, this diff removes it from `.flowconfig` 2. After removing it, there are a lot of flow errors, so, this diff fixes those flow errors. Reviewed By: jingping2015 Differential Revision: D32056933 fbshipit-source-id: 5128935ca989da066ffa08fd54de84f63c3dc7b8
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D32056933 |
supasate
added a commit
to supasate/facebook-nodejs-ads-sdk
that referenced
this pull request
Nov 3, 2021
Summary: Pull Request resolved: facebook/facebook-business-sdk-codegen#35 1. `types_first` has been deprecated (https://flow.org/en/docs/config/options/). It produces an error `".flowconfig: Unsupported option specified! (types_first)"`. So, this diff removes it from `.flowconfig` 2. After removing it, there are a lot of flow errors, so, this diff fixes those flow errors. Reviewed By: jingping2015 Differential Revision: D32056933 fbshipit-source-id: 24f3f2f1c68a1572cd2bcc0972b5b49b73372879
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
Summary: Pull Request resolved: facebook/facebook-nodejs-business-sdk#212 Pull Request resolved: #35 1. `types_first` has been deprecated (https://flow.org/en/docs/config/options/). It produces an error `".flowconfig: Unsupported option specified! (types_first)"`. So, this diff removes it from `.flowconfig` 2. After removing it, there are a lot of flow errors, so, this diff fixes those flow errors. Reviewed By: jingping2015 Differential Revision: D32056933 fbshipit-source-id: d26598ee
MihaelKonjevi
added a commit
to MihaelKonjevi/facebook-nodejs-business-sdk
that referenced
this pull request
Jan 31, 2024
Summary: Pull Request resolved: facebook/facebook-nodejs-business-sdk#212 Pull Request resolved: facebook/facebook-business-sdk-codegen#35 1. `types_first` has been deprecated (https://flow.org/en/docs/config/options/). It produces an error `".flowconfig: Unsupported option specified! (types_first)"`. So, this diff removes it from `.flowconfig` 2. After removing it, there are a lot of flow errors, so, this diff fixes those flow errors. Reviewed By: jingping2015 Differential Revision: D32056933 fbshipit-source-id: d26598ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
types_firsthas been deprecated (https://flow.org/en/docs/config/options/). It produces an error".flowconfig: Unsupported option specified! (types_first)". So, this diff removes it from.flowconfigAfter removing it, there are a lot of flow errors, so, this diff fixes those flow errors.
Reviewed By: jingping2015
Differential Revision: D32056933