Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Deprecated npm Package request with axios #257

Closed
wants to merge 8 commits into from

Conversation

genlyken
Copy link

@genlyken genlyken commented Aug 8, 2023

Replace Deprecated npm Package 'request'
Using axios.

@genlyken
Copy link
Author

genlyken commented Aug 8, 2023

Tested by creating Campaign, Adset and Ads.

useMultipartFormData doesn't seem to be used so I couldn't test it.
Screenshot 2023-08-07 at 5 29 05 PM

@facebook-github-bot
Copy link
Contributor

Hi @genlyken!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@stcheng stcheng changed the title Requests 1 Replace Deprecated npm Package request with axios Aug 8, 2023
@stcheng
Copy link
Contributor

stcheng commented Aug 8, 2023

@genlyken thank you so much for submitting this PR. To complete CLA check, please go to here: https://code.facebook.com/cla and finish the steps. I will meanwhile try to evaluate if this PR works as expected with some tests. Appreciate your contribution.

@stcheng
Copy link
Contributor

stcheng commented Aug 14, 2023

closing this with the commit a2d64d9

@stcheng stcheng closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants