Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API version to v2.10 #7

Closed

Conversation

josescasanova
Copy link
Contributor

I got a deprecation warning today stating v2.9 won't be available after November 6th, 2017. I went ahead and updated to v2.10. I checked the change log and didn't see any breaking changes for this: https://developers.facebook.com/docs/graph-api/changelog/breaking-changes

image

@josescasanova
Copy link
Contributor Author

It would be great if we can get this merged before Monday, November 13, 2017, since thats when the API will be deprecated.

@josescasanova
Copy link
Contributor Author

The latest version is v2.11, should I upgrade the package to that?

@Ivkaa
Copy link

Ivkaa commented Nov 8, 2017

@josescasanova I think there should be definitely a release supporting v2.10. Also this is breaking change, so package.json should be changed too. Let's wait until its published on npm. I made new issue with v2.11 so we won't forget about it until that :)

@josescasanova
Copy link
Contributor Author

@Ivkaa should I change the version the version in package.json to 2.9.2 (or 3.0.0), or should I let the person/group publishing the npm package handle that?

I'm going to create a v2.11 soon!

@Ivkaa
Copy link

Ivkaa commented Nov 8, 2017

@josescasanova imho 3.0.0 because for users that have in app settings another version, the api wont work. But maybe better solution would be to let users decide which api to use (as there are more versions and will be in future too) and have a preset one and only when that one will change, the version will need to be changed.

@josescasanova
Copy link
Contributor Author

@Ivkaa Agreed on 3.0.0! I'm going to let @zanyaziz handle that since he is the owner of the repo and he handled it last time (82e19f3)

@zanyaziz zanyaziz force-pushed the master branch 3 times, most recently from a31ba3c to e7ede57 Compare November 9, 2017 00:18
@zanyaziz
Copy link
Contributor

zanyaziz commented Nov 9, 2017

Hey guys,

There are a few new nodes/edges that need to be updated. I am pushing a new diff shortly with all the changes for v2.11 version of the sdk. Closing this out.

@zanyaziz zanyaziz closed this Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants