Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDefaultRequestHeaders() is misspelled as getDefaultRequestHeaderds() #569

Closed
ricky-cortopassi opened this issue Jan 12, 2023 · 1 comment
Closed

getDefaultRequestHeaders() is misspelled as getDefaultRequestHeaderds() #569

ricky-cortopassi opened this issue Jan 12, 2023 · 1 comment

Comments

@ricky-cortopassi
Copy link

Facebook PHP Business SDK Issue

https://github.com/facebook/facebook-php-business-sdk/blob/main/src/FacebookAds/Http/Client.php#L128

getDefaultRequestHeaderds() ( current )
getDefaultRequestHeaders() ( expect it to be )
@natewiebe13 natewiebe13 mentioned this issue Jan 13, 2023
Closed
2 tasks
@natewiebe13
Copy link
Contributor

This code is actually pulled in from the codegen repo. I've made a PR there: facebook/facebook-business-sdk-codegen#60

@stcheng stcheng closed this as completed Jan 28, 2023
facebook-github-bot pushed a commit that referenced this issue Jan 28, 2023
@natewiebe13 @facebook-github-bot
Fix function typo in a backwards compatible way (#60)
a3e9d1f 
Summary:
## Checklist

- [x] I've read the [Contributing Guidelines](CONTRIBUTING.md) and the [Code of Conduct](CODE_OF_CONDUCT.md)
- [x] I've completed the [Contributor License Agreement](https://developers.facebook.com/opensource/cla)

## Pull Request Details

Fix typo in a backwards compatible way, fixes #569

X-link: facebook/facebook-business-sdk-codegen#60

Reviewed By: mengxuanzhangz

Differential Revision: D42564624

Pulled By: stcheng

fbshipit-source-id: 1b443f47dfe6e007ba4890a7214c8cab56aa07e0
facebook-github-bot pushed a commit to facebook/facebook-business-sdk-codegen that referenced this issue Jan 28, 2023
@natewiebe13 @facebook-github-bot
Fix function typo in a backwards compatible way (#60)
b864161 
Summary:
## Checklist

- [x] I've read the [Contributing Guidelines](CONTRIBUTING.md) and the [Code of Conduct](CODE_OF_CONDUCT.md)
- [x] I've completed the [Contributor License Agreement](https://developers.facebook.com/opensource/cla)

## Pull Request Details

Fix typo in a backwards compatible way, fixes facebook/facebook-php-business-sdk#569

Pull Request resolved: #60

Reviewed By: mengxuanzhangz

Differential Revision: D42564624

Pulled By: stcheng

fbshipit-source-id: 1b443f47dfe6e007ba4890a7214c8cab56aa07e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix function typo in a backwards compatible way natewiebe13/facebook-business-sdk-codegen
3 participants
@natewiebe13 @stcheng @ricky-cortopassi