Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 Deprecation #570

Closed
davidistores opened this issue Jan 17, 2023 · 4 comments
Closed

PHP 8.1 Deprecation #570

davidistores opened this issue Jan 17, 2023 · 4 comments

Comments

@davidistores
Copy link

Facebook PHP Business SDK Issue

Since we want to handle bugs more efficiently, we've decided to close issue reporting in Github and move to our dedicated bug reporting channel.
If you encounter a bug with Business SDK (PHP), please report the issue at our developer bug reporting channel.

At this file src/FacebookAds/Object/AbstractCrudObject.php
inside the __constructor you are using default valuue "null" for $id that throwing php 8.1 error while trying execute strpos() on null on Line 64

Please change the default vlaue to empty string I guess
thanks alot
issue-screen-2
issue-screen-1

@natewiebe13
Copy link
Contributor

Fixed in facebook/facebook-business-sdk-codegen#50

Once the codegen files get imported into this repo, the issue will be resolved.

@davidistores
Copy link
Author

How can I resolve it vai composer ?

@natewiebe13
Copy link
Contributor

Since it's ultimately a fix from another repo, I'd probably tackle it by using patches. If you wanted a purely composer way to do it, I'd probably recommend https://github.com/cweagans/composer-patches

@stcheng
Copy link
Contributor

stcheng commented Jan 19, 2023

The latest version has fixed this issue. Thanks.

@stcheng stcheng closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants