explain that account_id should begin with "act_" #37
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
| @@ -26,7 +26,7 @@ | |||
| $access_token = null; | |||
| $app_id = null; | |||
| $app_secret = null; | |||
| $account_id = null; | |||
| $account_id = null; // should begin with "act_" (without the quotes) | |||
There was a problem hiding this comment.
actually you need the quotes as it's a string
There was a problem hiding this comment.
I'm not sure how to word it, what I was saying is that it should be $account_id = 'act_xxx'; and should not be $account_id = '"act_"xxx';
|
I updated the comment so as not to confuse the user by mentioning the quotes. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@cornernote, can you please squash the 2 commits? |
|
Hi @pruno, I'm not sure how. I can do a new pull request, is that ok, or is there a better way? |
|
@cornernote, if you are not familiar with squashing: |
squishes commits as requested in facebook#37
relates to #36