New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve PHP 8.1 Deprecations #554
Conversation
need merge |
Thanks for your contribution. We'll evaluate if we would like to bump the version requirements, but the PR looks good. |
@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@natewiebe13 for this repository, it is only the generated files from the original source stored here. If you want to update the files, you shall submit the PR in the facebook-business-sdk-codegen repository. Thanks. |
@natewiebe13 Will you make it? |
@stcheng I only see 2 of the 11 files in the code gen repo:
Are the other files somewhere else? Or how should I proceed with the changes? |
I have also started a PR for those files here: facebook/facebook-business-sdk-codegen#40 |
@natewiebe13 thanks i'll check it out. |
@stcheng any updates on this? |
waiting for this PR facebook/facebook-business-sdk-codegen#40 to get merged |
This resolves php 8.1 deprecations in a backwards compatible way.
More ideally, return types should be added to function definitions, but this would no longer support PHP 5.6 as described in the README. If the team is open to bumping up version requirements to only include supported PHP versions (7.4+), I can revisit this to add return types instead.