Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve PHP 8.1 Deprecations #554

Closed
wants to merge 2 commits into from

Conversation

natewiebe13
Copy link
Contributor

This resolves php 8.1 deprecations in a backwards compatible way.

More ideally, return types should be added to function definitions, but this would no longer support PHP 5.6 as described in the README. If the team is open to bumping up version requirements to only include supported PHP versions (7.4+), I can revisit this to add return types instead.

@NelinD
Copy link

NelinD commented Jun 1, 2022

need merge

@stcheng
Copy link
Contributor

stcheng commented Jun 2, 2022

Thanks for your contribution. We'll evaluate if we would like to bump the version requirements, but the PR looks good.

@facebook-github-bot
Copy link

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@stcheng
Copy link
Contributor

stcheng commented Jun 3, 2022

@natewiebe13 for this repository, it is only the generated files from the original source stored here. If you want to update the files, you shall submit the PR in the facebook-business-sdk-codegen repository. Thanks.

@stcheng stcheng closed this Jun 3, 2022
@NelinD
Copy link

NelinD commented Jun 8, 2022

@natewiebe13 Will you make it?

@natewiebe13
Copy link
Contributor Author

@natewiebe13
Copy link
Contributor Author

I have also started a PR for those files here: facebook/facebook-business-sdk-codegen#40

@stcheng
Copy link
Contributor

stcheng commented Jun 8, 2022

@natewiebe13 thanks i'll check it out.

@natewiebe13
Copy link
Contributor Author

@stcheng any updates on this?

@ujwaldhakal
Copy link

waiting for this PR facebook/facebook-business-sdk-codegen#40 to get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants