Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default state to exception status code #581

Closed
wants to merge 1 commit into from

Conversation

MartinTebenko
Copy link
Contributor

@MartinTebenko MartinTebenko commented Jun 8, 2023

Issue Title: Passing null to parameter #2 ($code) of type int is deprecated
Issue Description:
Problem location -> "facebook/php-business-sdk/src/FacebookAds/Http/Exception/RequestException.php(90): Tracy\DevelopmentStrategy::handleError"
Exception -> Passing null to parameter #2 ($code) of type int is deprecated

Debugging Data:
Kernel version -> Linux klarka9.stable.cz 3.10.0-1160.66.1.el7.x86_64 #1 SMP Wed May 18 16:02:34 UTC 2022 x86_64
Runtime -> PHP 8.1.18

Stack Trace -> [ErrorException: Exception::__construct(): Passing null to parameter #2 ($code) of type int is deprecated
x27 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Exception/RequestException.php(90): Tracy\DevelopmentStrategy::handleError
x26 /vendor/tracy/tracy/src/Tracy/Debugger/Debugger.php(358): Tracy\Debugger::errorHandler
x25 internal: call_user_func_array
x24 /vendor/facebook/php-business-sdk/src/FacebookAds/CrashReporter.php(154): FacebookAds\CrashReporter::FacebookAds{closure}
x23 internal: Exception::__construct
x22 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Exception/RequestException.php(90): FacebookAds\Http\Exception\RequestException::__construct
x21 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Exception/EmptyResponseException.php(40): FacebookAds\Http\Exception\EmptyResponseException::__construct
x20 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Client.php(220): FacebookAds\Http\Client::sendRequest
x19 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Request.php(286): FacebookAds\Http\Request::execute
x18 /vendor/facebook/php-business-sdk/src/FacebookAds/Api.php(165): FacebookAds\Api::executeRequest
x17 /vendor/facebook/php-business-sdk/src/FacebookAds/Api.php(214): FacebookAds\Api::call
x16 /vendor/facebook/php-business-sdk/src/FacebookAds/ApiRequest.php(187): FacebookAds\ApiRequest::execute]

@facebook-github-bot
Copy link

Hi @MartinTebenko!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@MartinTebenko MartinTebenko marked this pull request as ready for review June 8, 2023 08:06
@facebook-github-bot
Copy link

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@stcheng merged this pull request in df67b5b.

facebook-github-bot pushed a commit to facebook/facebook-business-sdk-codegen that referenced this pull request Jun 27, 2023
Summary:
Issue Title: Passing null to parameter facebook/facebook-php-business-sdk#2 ($code) of type int is deprecated
Issue Description:
Problem location -> "facebook/php-business-sdk/src/FacebookAds/Http/Exception/RequestException.php(90): Tracy\DevelopmentStrategy::handleError"
Exception -> Passing null to parameter facebook/facebook-php-business-sdk#2 ($code) of type int is deprecated

Debugging Data:
Kernel version -> Linux klarka9.stable.cz 3.10.0-1160.66.1.el7.x86_64 facebook/facebook-php-business-sdk#1 SMP Wed May 18 16:02:34 UTC 2022 x86_64
Runtime -> PHP 8.1.18

Stack Trace -> [ErrorException: Exception::__construct(): Passing null to parameter facebook/facebook-php-business-sdk#2 ($code) of type int is deprecated
x27 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Exception/RequestException.php(90): Tracy\DevelopmentStrategy::handleError
x26 /vendor/tracy/tracy/src/Tracy/Debugger/Debugger.php(358): Tracy\Debugger::errorHandler
x25 [internal](0): call_user_func_array
x24 /vendor/facebook/php-business-sdk/src/FacebookAds/CrashReporter.php(154): FacebookAds\CrashReporter::FacebookAds\{closure}
x23 [internal](0): Exception::__construct
x22 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Exception/RequestException.php(90): FacebookAds\Http\Exception\RequestException::__construct
x21 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Exception/EmptyResponseException.php(40): FacebookAds\Http\Exception\EmptyResponseException::__construct
x20 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Client.php(220): FacebookAds\Http\Client::sendRequest
x19 /vendor/facebook/php-business-sdk/src/FacebookAds/Http/Request.php(286): FacebookAds\Http\Request::execute
x18 /vendor/facebook/php-business-sdk/src/FacebookAds/Api.php(165): FacebookAds\Api::executeRequest
x17 /vendor/facebook/php-business-sdk/src/FacebookAds/Api.php(214): FacebookAds\Api::call
x16 /vendor/facebook/php-business-sdk/src/FacebookAds/ApiRequest.php(187): FacebookAds\ApiRequest::execute]

X-link: facebook/facebook-php-business-sdk#581

Reviewed By: mengxuanzhangz

Differential Revision: D47028260

Pulled By: stcheng

fbshipit-source-id: 946f72bc8b8684bb71e1b73e31fe251cc74979ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants