This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
fixed issue#598 #599
Merged
fixed issue#598 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> if composer isn't used, we need to include the polyfills manually
ghost
added
the
| @@ -32,6 +32,10 @@ | |||
| throw new Exception('The Facebook SDK requires PHP version 5.4 or higher.'); | |||
| } | |||
|
|
|||
| if (defined('FACEBOOK_SDK_POLYFILLS_LOADED') === false) { | |||
There was a problem hiding this comment.
I dont think the constant use useful, you can just require once the polyfills file :)
|
What if you require polyfills.php in SignedRequest.php? this worked for me |
|
@jrgonzalezrios The polyfills script is needed in other files as well so it needs to be loaded with the autoloader. :) |
|
@voku Any way you can make the changes mentioned above so we can wrap this one up? :) |
|
I'm going to go ahead and merge this one in and finish it off based on the feedback. Thanks @voku! :) |
SammyK
added a commit
to SammyK/php-graph-sdk
that referenced
this pull request
Aug 6, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #598
-> if composer isn't used, we need to include the polyfills manually