feat: Us e with when opening file to ensure closure ✨ (#604)

Summary: Pull Request resolved: #604

Reviewed By: mengxuanzhangz

Differential Revision: D49881089

Pulled By: stcheng

fbshipit-source-id: c43169f1924b9336352e029e952da91311f019de

examples/async.py

@@ -33,10 +33,8 @@
 
 this_dir = os.path.dirname(__file__)
 config_filename = os.path.join(this_dir, 'config.json')
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 api = FacebookAdsApi.init(access_token=config['access_token'])
 account_id = config['act_id']
 

examples/batch_create.py

@@ -22,6 +22,7 @@
 Creates several ads using batch calls.
 """
 
+
 from facebook_business import FacebookSession
 from facebook_business import FacebookAdsApi
 from facebook_business.adobjects.adaccount import AdAccount
@@ -35,10 +36,8 @@
 this_dir = os.path.dirname(__file__)
 config_filename = os.path.join(this_dir, 'config.json')
 
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 ### Setup session and api objects
 session = FacebookSession(
     config['app_id'],

examples/batch_pause.py

@@ -22,6 +22,7 @@
 Pauses all active ad campaigns using batch calls.
 """
 
+
 from facebook_business import FacebookSession
 from facebook_business import FacebookAdsApi
 from facebook_business.adobjects.adaccount import AdAccount
@@ -35,10 +36,8 @@
 this_dir = os.path.dirname(__file__)
 config_filename = os.path.join(this_dir, 'config.json')
 
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 ### Setup session and api objects
 session = FacebookSession(
     config['app_id'],

examples/custom_audience_utils.py

@@ -24,6 +24,7 @@
 https://github.com/facebook/facebook-python-ads-sdk
 """
 
+
 from facebook_business import FacebookAdsApi
 from facebook_business.adobjects.adaccount import AdAccount
 from facebook_business.adobjects.customaudience import CustomAudience
@@ -38,11 +39,8 @@
 this_dir = os.path.dirname(__file__)
 config_filename = os.path.join(this_dir, 'config.json')
 
-### Setup session and api objects
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 auth_info = (
     config['app_id'],
     config['app_secret'],

examples/dpa-update/dpa_search.py

@@ -29,10 +29,8 @@
 import sys
 sys.path.insert(1, os.path.join(this_dir, os.pardir, os.pardir))
 
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 from facebook_business.api import FacebookAdsApi
 from facebook_business.adobjects.productcatalog import ProductCatalog
 from facebook_business.adobjects.productitem import ProductItem

examples/dpa-update/dpa_update.py

@@ -30,10 +30,8 @@
 import sys
 sys.path.insert(1, os.path.join(this_dir, os.pardir, os.pardir))
 
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 from facebook_business.api import FacebookAdsApi
 from facebook_business.adobjects.productcatalog import ProductCatalog
 from facebook_business.adobjects.productitem import ProductItem

examples/read_objects.py

@@ -22,6 +22,7 @@
 Prints account permissions and campaign statistics.
 """
 
+
 from facebook_business import FacebookSession
 from facebook_business import FacebookAdsApi
 from facebook_business.adobjects.campaign import Campaign as AdCampaign
@@ -35,10 +36,8 @@
 this_dir = os.path.dirname(__file__)
 config_filename = os.path.join(this_dir, 'config.json')
 
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 ### Setup session and api objects
 session = FacebookSession(
     config['app_id'],

examples/simple_create.py

@@ -22,6 +22,7 @@
 Creates an ad through a utility function.
 """
 
+
 from facebook_business import FacebookSession
 from facebook_business import FacebookAdsApi
 from facebook_business.adobjects.adaccount import AdAccount
@@ -36,10 +37,8 @@
 this_dir = os.path.dirname(__file__)
 config_filename = os.path.join(this_dir, 'config.json')
 
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 ### Setup session and api objects
 session = FacebookSession(
     config['app_id'],
@@ -88,10 +87,9 @@
         'ad_format': AdPreview.AdFormat.right_column_standard
     })
     preview_filename = os.path.join(this_dir, 'preview_ad.html')
-    preview_file = open(preview_filename, 'w')
-    preview_file.write(
-        "<html><head><title>Facebook Ad Preview</title><body>%s</body></html>"
-        % preview.get_html()
-    )
-    preview_file.close()
+    with open(preview_filename, 'w') as preview_file:
+        preview_file.write(
+            "<html><head><title>Facebook Ad Preview</title><body>%s</body></html>"
+            % preview.get_html()
+        )
     print('**** %s has been created!' % preview_filename)

examples/upload_video.py

@@ -22,6 +22,7 @@
 Upload a video to adaccount
 """
 
+
 import sys
 import os
 
@@ -34,10 +35,8 @@
 
 config_filename = os.path.join(sdk_path, './config.json')
 
-config_file = open(config_filename)
-config = json.load(config_file)
-config_file.close()
-
+with open(config_filename) as config_file:
+    config = json.load(config_file)
 ### Setup session and api objects
 session = FacebookSession(
     config['app_id'],