Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch remote creation does not properly encode NoneType in id field #30

Closed
grantt opened this issue Jan 22, 2015 · 2 comments
Closed

Batch remote creation does not properly encode NoneType in id field #30

grantt opened this issue Jan 22, 2015 · 2 comments

Comments

@grantt
Copy link

grantt commented Jan 22, 2015

When adding a remote_create call to a batch an error occurs where the None value for id cannot be properly quoted by urllib.parse.quote. At this point in the add call the params should already be valid JSON thanks to _top_level_param_json_encode. Unfortunately, this function only attempts to apply json.dumps to a value if it is an instance of collections.Mapping, collections.Sequence, or bool and is not an instance of six.string_types. None evades this conditional and is left unmodified in the parameters leaving it to fail when it is passed later as a parameter.

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@rituparnamukherjee
Copy link
Contributor

I am going to close this one out. Since we have updated the batch call logic. If you still see this, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants