EdgeIterator.total() should raise if _total_count is None #53
Conversation
|
Cool! Thanks for the cleanup. Could you actually raise and catch a different (new) Exception? Create |
|
yes of course! |
|
done, when do you think you'll do a pip release of the SDK? I also take the opportunity to tell you that we now run the integration tests on our own account, automatically. As a result, as we discover errors / bugs / unexpected behaviours, we'll contribute to strengthen your integrations tests :) |
|
@m-vdb we have a broken test at the moment that is slated to be fixed early next week. We'll do a pip release then. :) |
|
Pulling in for review, could you modify all lines to be less than 80 characters? |
|
ah yes you have strict linter :) no problem |
|
there you go, I can rebase if you want. Thanks for the release, will wait for it :) |
|
@ebzlo any news? |
|
@ebzlo gentle ping :) |
Summary: #53 total() currently fails silently Test Plan: non provided
Summary: facebook#53 total() currently fails silently Test Plan: non provided
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
@ebzlo this PR is cleaner, with unit tests