Fixed bug in VideoUploadSession with timeout and interval #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@jingping2015 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebook/facebook-business-sdk-codegen
that referenced
this pull request
Jun 3, 2019
Summary: I have no idea why but production code lacks 2 mandatory arguments when calling `VideoEncodingStatusChecker.waitUntilReady`. I have fixed it with the default values. Pull Request resolved: facebook/facebook-python-business-sdk#543 Reviewed By: codytwinton Differential Revision: D15558296 Pulled By: jingping2015 fbshipit-source-id: e435fb6f
|
@jingping2015 merged this pull request in 7a7df42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why but production code lacks 2 mandatory arguments when calling
VideoEncodingStatusChecker.waitUntilReady. I have fixed it with the default values.