Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix Minor Issue ✨ #601

Closed
wants to merge 1 commit into from
Closed

Chore: Fix Minor Issue ✨ #601

wants to merge 1 commit into from

Conversation

yezz123
Copy link
Contributor

@yezz123 yezz123 commented Nov 6, 2021

  • Convert for loop into list comprehension
  • Use with when opening file to ensure closure

@stcheng
Copy link
Contributor

stcheng commented Oct 3, 2023

hi @yezz123 could you help rebase the pr to the latest master?

@facebook-github-bot
Copy link

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@stcheng merged this pull request in 7511fe3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants