fix: CustomAudienceHelpers is broken for separation of positional and keyword arguments in Ruby 3.0 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdakira
force-pushed
the
fix-custom-audience-for-ruby3
branch
from
5f3638d
to
cb2f638
Compare
osdakira
changed the title
|
Excuse my sudden mention, Sir. I wanted to mentions it, but I didn't know who to mentions it to, so I asked you, the latest reviewer. [Issues] |
|
@alanho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@osdakira thanks for the report. we're working on merging this into main branch |
|
@alanho thank you for your quick response. I appreciate your working. |
facebook-github-bot
pushed a commit
to facebook/facebook-business-sdk-codegen
that referenced
this pull request
Aug 1, 2023
… keyword arguments in Ruby 3.0 Summary: `CustomAudienceHelpers` is broken due to ruby3.0 spec changes. This should be fixed since the minimum supported version is ruby3.0. https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ X-link: facebook/facebook-ruby-business-sdk#200 Reviewed By: stcheng Differential Revision: D47914109 Pulled By: alanho fbshipit-source-id: 4bcfa288fbeaa5a3031b7eb3e9abe5eba827c0cd
afn
pushed a commit
to cygnuseducation/facebook-ruby-business-sdk
that referenced
this pull request
Nov 1, 2023
… keyword arguments in Ruby 3.0 (facebook#200) Summary: `CustomAudienceHelpers` is broken due to ruby3.0 spec changes. This should be fixed since the minimum supported version is ruby3.0. https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ Pull Request resolved: facebook#200 Reviewed By: stcheng Differential Revision: D47914109 Pulled By: alanho fbshipit-source-id: 4bcfa288fbeaa5a3031b7eb3e9abe5eba827c0cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomAudienceHelpersis broken due to ruby3.0 spec changes.This should be fixed since the minimum supported version is ruby3.0.
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/