Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not regenerate AndroidManifest post build #29

Open
lacostej opened this issue Jul 2, 2016 · 1 comment
Open

Do not regenerate AndroidManifest post build #29

lacostej opened this issue Jul 2, 2016 · 1 comment

Comments

@lacostej
Copy link

lacostej commented Jul 2, 2016

The FacebookPostProcess currently modifies the default AndroidManifest.xml post build.
This decision is based on whether the default Unity3d AndroidManifest.xml has been modified to contain the expected Facebook configurations.

In our project, we decided to use an AndroidManifest.xml fragment instead. Our default Unity3d AndroidManifest.xml should thus not contain the facebook changes and the Postprocess operation causes confusion.

Also given that we build multiple product variants from the same source tree, we use pre-build techniques to customize that fragment AndroidManifest based on our needs. The default generated one isn't necessarily the one we want to have.

We would recommend to not call GenerateManifest() at all in the Post build or at least to make it so that we can disable that behaviour without having to patch the SDK at each update. Also the use of an AndroidManifest fragment could be a good thing (e.g. Assets/Plugins/Android/Facebook/AndroidManifest.xml)

@bblpny
Copy link

bblpny commented Sep 28, 2016

I agree and believe this should be optional as well, It seems unnecessary to have this be automated in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants